GNOME Bugzilla – Bug 695967
Take advantage of Unicode
Last modified: 2016-10-03 19:20:57 UTC
Hallo NetworkManager applet devs I was wondering what the rationale is behind changing e.g. all the ellipsis characters back from unicode to ascii. We are making the reverse movement for a lot of other modules for GNOME, so why exactly are you going back? Regards Kenneth
This probably had something to do with RHEL6... either we intentionally changed everything back to ascii ellipses to make it easier to backport changes to RHEL6, or else we accidentally did it while forward-porting a change that had been originally done in RHEL6. Anyway, if GNOME as a whole is moving to unicode ellipses then we're happy to take patches to fix it. (Ideally the patches should change both the .c files and the .po files so that we don't break large numbers of translations.)
Are any patches coming for this?
Created attachment 336690 [details] [review] Use Unicode in translatable strings Attached patch converts ASCII characters to Unicode, as recommended by <https://developer.gnome.org/hig/stable/typography.html>.
Created attachment 336693 [details] [review] Unmark empty strings and numbers from translation While I'm at it, here is a couple of other improvement patches to translatable strings.
Created attachment 336694 [details] [review] Remove double spaces from translatable strings
patches lgtm
So can I push them to git now?
LGTM
merged to master: https://git.gnome.org/browse/network-manager-applet/commit/?id=05c64b282ffc7b9a205c509dd3c7b747cacff62f Thanks Piotr for the patches!
Thank you for such a quick reaction. Should I submit similar patches for each VPN plug-in, or maybe I could just commit the changes directly?
(In reply to Piotr Drąg from comment #10) > Thank you for such a quick reaction. > > Should I submit similar patches for each VPN plug-in, or maybe I could just > commit the changes directly? Please go ahead and just commit them directly! Thanks (you probably noticed that there are not "nm-1-2" nor "nm-1-4" branches for the plugins. There is no need to created them, fix it only on master. It seems not necessary to fix it for the old-stable branches "nm-1-2" or older).