After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695951 - Control + back toolbar button creates an empty tab
Control + back toolbar button creates an empty tab
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
git master
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-16 02:57 UTC by Gustavo Noronha (kov)
Modified: 2013-03-19 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Load back item when back is clicked with control held/middle clicked, for wk2 (2.49 KB, patch)
2013-03-16 03:08 UTC, Gustavo Noronha (kov) 		none Details | Review
Load back item when back is clicked with control held/middle clicked, for wk2 (2.58 KB, patch)
2013-03-18 20:35 UTC, Gustavo Noronha (kov) 		committed Details | Review

Description Gustavo Noronha (kov) 2013-03-16 02:57:55 UTC 
SSIA, the problem is the current code assumes the back/forward list is successfully copied. This assumption doesn't hold for WebKit2, so we should just grab the URI of the back item and load it.
Comment 1 Gustavo Noronha (kov) 2013-03-16 03:08:16 UTC 
Created attachment 239018 [details] [review]
Load back item when back is clicked with control held/middle clicked, for wk2
Comment 2 Gustavo Noronha (kov) 2013-03-18 20:35:28 UTC 
Created attachment 239188 [details] [review]
Load back item when back is clicked with control held/middle clicked, for wk2

In WebKit2 the back/forward list is not copiable, so that assumption
doesn't hold, and the current code path fails. With this change we
tell EphyShell to not copy the list and load the URL held by the back
item of the existing WebView in the new WebView instead, for WebKit2.
Comment 3 Gustavo Noronha (kov) 2013-03-18 20:36:21 UTC 
Now with 100% less breakage of the normal back button click!
Comment 4 Xan Lopez 2013-03-19 08:17:00 UTC 
Review of attachment 239188 [details] [review]:

Seems to work fine. So sad we cannot copy the bf list. Can you add a FIXME in the code pointing out the old WK1 code path should really work?
Comment 5 Gustavo Noronha (kov) 2013-03-19 13:00:29 UTC 
Comment on attachment 239188 [details] [review]
Load back item when back is clicked with control held/middle clicked, for wk2

10f300b27a14c450c9a20b12c23f4e542942655c

Done that, thanks.