After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695939 - Use common_name if present when parsing iso-codes files for language names
Use common_name if present when parsing iso-codes files for language names
Status: RESOLVED OBSOLETE
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-15 19:58 UTC by Gunnar Hjalmarsson
Modified: 2018-09-21 16:35 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6

Attachments
use common_name (1.44 KB, patch)
2013-03-15 19:58 UTC, Gunnar Hjalmarsson 		none Details | Review
use common_name 2 (2.15 KB, patch)
2017-11-15 19:21 UTC, Gunnar Hjalmarsson 		none Details | Review

Description Gunnar Hjalmarsson 2013-03-15 19:58:11 UTC 
Created attachment 239006 [details] [review]
use common_name

gdm-languages.c contains code for parsing XML files provided by the iso-codes package. As regards country names, the string in the 'common_name' field is used at first hand.

Last autumn a 'common_name' field was introduced also in the files for language names, so gdm-languages.c should be modified accordingly. Currently this change means that the language code bn will give you "Bangla" instead of "Bengali".
Comment 1 Jeremy Bicha 2013-03-30 14:16:38 UTC 
When you submit patches, could you rebase them against master instead of 3.6?
Comment 2 Gunnar Hjalmarsson 2013-03-30 14:32:08 UTC 
I would have done so in this case, if panels/common/gdm-languages.c had been present in 3.8. It's not, so I left it to someone who is familiar with the current code.
Comment 3 Matthias Clasen 2013-03-31 22:04:16 UTC 
the language handling code has moved to gnome-desktop
Comment 4 Gunnar Hjalmarsson 2013-03-31 23:00:07 UTC 
Thanks for letting us know. gnome-languages.c and gdm-languages.c are alike, and the attached patch applies to both files.
Comment 5 Bastien Nocera 2013-04-22 09:24:42 UTC 
Reassigning to gnome-desktop.
Comment 6 Bastien Nocera 2017-11-15 18:29:18 UTC 
Review of attachment 239006 [details] [review]:

Can you please rebase this patch and attach a version that's git-formatted, along with an explanation of why you're making this change?
Comment 7 Gunnar Hjalmarsson 2017-11-15 19:21:36 UTC 
Created attachment 363742 [details] [review]
use common_name 2
Comment 8 Gunnar Hjalmarsson 2017-11-15 19:23:50 UTC 
Same explanation as 4.5 years ago:
"Currently this change means that the language code bn will give you "Bangla" instead of "Bengali"."
Comment 9 GNOME Infrastructure Team 2018-09-21 16:35:49 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-desktop/issues/49.