After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695870 - commit "actor: Skip transitions on invisible actors" breaks working code - reproducer included
commit "actor: Skip transitions on invisible actors" breaks working code - re...
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-14 17:53 UTC by Rui Matos
Modified: 2013-03-14 22:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Reproducer (1.62 KB, text/plain)
2013-03-14 17:53 UTC, Rui Matos
Details

Description Rui Matos 2013-03-14 17:53:26 UTC
Created attachment 238918 [details]
Reproducer

Commit https://git.gnome.org/browse/clutter/commit/?h=clutter-1.14&id=0d65f9461ee2a02cf400e5d8aa40c07eca43cf7c breaks mutter's flash screen code[1]. A reproducer program using that code is attached.

[1] https://git.gnome.org/browse/mutter/tree/src/compositor/compositor.c#n1502
Comment 1 Emmanuele Bassi (:ebassi) 2013-03-14 22:00:51 UTC
I am *very* tempted to say that it's the intended behaviour, and that if you want to override it, you're welcome to use an explicit ClutterPropertyTransition — but it's also very late in the cycle, and I don't want to cause more breakage than necessary, so I think I'll just revert the commit from the clutter-1.14 branch.
Comment 2 Emmanuele Bassi (:ebassi) 2013-03-14 22:04:54 UTC
in theory, you should be able to queue an initial transition, but we short-circuit actors with 0 opacity, so the "was_painted" flag does not get unset and short-circuits the implicit transition as well.

I think we should probably ignore implicit transitions on allocation until the actor is painted once, and allow other implicit transitions to be "queued".
Comment 3 Emmanuele Bassi (:ebassi) 2013-03-14 22:05:31 UTC
revert pushed to the clutter-1.14 branch, and for master we'll see what we can do.