Created attachment 239014 [details] [review]
Add a welcome screen for when there are no locations added

Following the example of gnome-documents and gnome-clocks, add some
placeholder text when the content view is empty.
Then also tie the availability of the select button to the emptyness
of the view.

Patch is attached if you want to try it, I will merge it in master
after 3.8 is out.

Review of attachment 239014 [details] [review]:

The patch is not applying so I have not tested it.

Looking at the code it looks good to me, some minor comments inline...

::: src/world.js
@@ -175,0 +175,12 @@
+
+const WorldContentView = new Lang.Class({
+    Name: 'WorldContentView',
... 9 more ...

You could move here some of the implementation details that are now in window.js, in particular

iconView.connect('selection-mode-request', Lang.bind(this, function() {
   this.selection_mode = true;
}));

@@ -175,0 +175,14 @@
+
+const WorldContentView = new Lang.Class({
+    Name: 'WorldContentView',
... 11 more ...

Do we need to set a css class on the placeholder? In documents/clocks the placeholder has to have the same lighter background color user for the iconview, but without testing I am not sure if this apply for a dark theme app.

@@ -175,0 +175,19 @@
+
+const WorldContentView = new Lang.Class({
+    Name: 'WorldContentView',
... 16 more ...

Use the enumeration name instead of hardcoding 6 (I have not checked if it is available in gjs, but it should)

Attachment 239014 [details] pushed as 5bd0b2a - Add a welcome screen for when there are no locations added