After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695849 - share: Misc bug fixes
share: Misc bug fixes
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-14 14:26 UTC by Bastien Nocera
Modified: 2013-03-14 22:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
share: Never return empty arguments (770 bytes, patch)
2013-03-14 14:27 UTC, Bastien Nocera 		committed Details | Review
share: Use g_strdelimit() instead of biji_str_replace() (826 bytes, patch)
2013-03-14 14:27 UTC, Bastien Nocera 		committed Details | Review
share: No need for unused pipes (1.34 KB, patch)
2013-03-14 14:28 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2013-03-14 14:26:58 UTC 
.
Comment 1 Bastien Nocera 2013-03-14 14:27:00 UTC 
Created attachment 238877 [details] [review]
share: Never return empty arguments

This fixes xdg-email not working when the note is empty.

xdg-email: text argument missing for --subject option
Try 'xdg-email --help' for more information.
Comment 2 Bastien Nocera 2013-03-14 14:27:52 UTC 
Created attachment 238878 [details] [review]
share: Use g_strdelimit() instead of biji_str_replace()

This modifies the string in place, instead of splitting it,
and recreating it as biji_str_replace() does.
Comment 3 Bastien Nocera 2013-03-14 14:28:02 UTC 
Created attachment 238879 [details] [review]
share: No need for unused pipes
Comment 4 Pierre-Yves Luyten 2013-03-14 20:21:46 UTC 
Review of attachment 238877 [details] [review]:

yes
Comment 5 Pierre-Yves Luyten 2013-03-14 20:22:11 UTC 
Review of attachment 238878 [details] [review]:

good
Comment 6 Pierre-Yves Luyten 2013-03-14 20:22:29 UTC 
Review of attachment 238879 [details] [review]:

ok
Comment 7 Bastien Nocera 2013-03-14 22:04:50 UTC 
Pushed to master

Attachment 238877 [details] pushed as c6ffb00 - share: Never return empty arguments
Attachment 238878 [details] pushed as d753a6f - share: Use g_strdelimit() instead of biji_str_replace()
Attachment 238879 [details] pushed as 52835f2 - share: No need for unused pipes