After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695835 - Misc bug fixes
Misc bug fixes
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: cdda backend
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-14 10:40 UTC by Bastien Nocera
Modified: 2013-03-14 22:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
cdda: Remove unneeded function argument (1.49 KB, patch)
2013-03-14 10:41 UTC, Bastien Nocera
committed Details | Review
cdda: Remove leading '/' from the filenames (1.10 KB, patch)
2013-03-14 10:42 UTC, Bastien Nocera
committed Details | Review
cdda: Fix warnings for each track on the CD (987 bytes, patch)
2013-03-14 10:42 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2013-03-14 10:40:51 UTC
.
Comment 1 Bastien Nocera 2013-03-14 10:41:50 UTC
Created attachment 238859 [details] [review]
cdda: Remove unneeded function argument
Comment 2 Bastien Nocera 2013-03-14 10:42:04 UTC
Created attachment 238860 [details] [review]
cdda: Remove leading '/' from the filenames
Comment 3 Bastien Nocera 2013-03-14 10:42:15 UTC
Created attachment 238861 [details] [review]
cdda: Fix warnings for each track on the CD

(process:22937): GLib-CRITICAL **: g_convert: assertion `str != NULL' failed
for each of the tracks as we tried to convert the genre (which was NULL)
Comment 4 Bastien Nocera 2013-03-14 22:03:43 UTC
Pushed to master

Attachment 238859 [details] pushed as aac8860 - cdda: Remove unneeded function argument
Attachment 238860 [details] pushed as 51ad0a9 - cdda: Remove leading '/' from the filenames
Attachment 238861 [details] pushed as 7855cb4 - cdda: Fix warnings for each track on the CD