After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695774 - rtsp-client: add gst_rtsp_client_get_uri()
rtsp-client: add gst_rtsp_client_get_uri()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal enhancement
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-13 13:51 UTC by Patricia Muscalu
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtsp-client: expose url (5.09 KB, patch)
2013-03-13 13:51 UTC, Patricia Muscalu 		needs-work Details | Review
rtsp-client: expose url (5.26 KB, patch)
2013-03-18 08:38 UTC, Patricia Muscalu 		committed Details | Review

Description Patricia Muscalu 2013-03-13 13:51:03 UTC 
Created attachment 238781 [details] [review]
rtsp-client: expose url

The patch exposes the client's url. This information is needed when the specific sdp fields are created (in the create_sdp virtual function) based on the requested url.
Comment 1 Tim-Philipp Müller 2013-03-16 15:43:23 UTC 
Comment on attachment 238781 [details] [review]
rtsp-client: expose url

Quite a bit of _url/_uri confusion in our API :) I think _uri dominates though, so I'm happy with that unless Wim feels differently.

There's one thing which needs fixing: the function should actually return a copy or ref or the GstRTSPUrl, not just return the client->uri pointer. That's needed for thread-safety reasons, but also for bindings given the (transfer full) annotation. Also seems like the right thing to do. Unit tests will need updating for that then.
Comment 2 Patricia Muscalu 2013-03-18 08:38:09 UTC 
Created attachment 239099 [details] [review]
rtsp-client: expose url
Comment 3 Patricia Muscalu 2013-03-18 08:40:02 UTC 
Thank you for your response.

I've corrected the patch: the copy of the GstRTSPUrl is now returned by the _get_uri function.
Comment 4 Tim-Philipp Müller 2013-03-19 00:03:57 UTC 
commit 8a08fddb41c7a25e025eaccf92961e1797fd6576
Author: Patricia Muscalu <patricia@axis.com>
Date:   Mon Mar 18 09:25:54 2013 +0100

    rtsp-client: expose uri