After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695719 - lsw dummy test intermittently segfaults
lsw dummy test intermittently segfaults
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: libsocialweb backend
0.9.x
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-12 17:07 UTC by Simon McVittie
Modified: 2013-03-13 12:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't do manual memory management for libsocialweb Contact structs (1.68 KB, patch)
2013-03-12 17:07 UTC, Simon McVittie 		committed Details | Review

Description Simon McVittie 2013-03-12 17:07:09 UTC 
Created attachment 238716 [details] [review]
Don't do manual memory management for libsocialweb Contact  structs

GObject (and hence Vala) already knows how to memory-manage a Contact,
because it's a boxed type. Trying to do our own memory-management
anyway results in an occasional (50%?) double-free and crash.
Comment 1 Simon McVittie 2013-03-12 17:09:51 UTC 
I've verified that the generated C setter still copies it:

	SwContact* _tmp0_;
	SwContact* _tmp1_;
	g_return_if_fail (self != NULL);
	_tmp0_ = value;
	_tmp1_ = __vala_SwContact_copy0 (_tmp0_);
	__vala_SwContact_free0 (self->priv->_lsw_contact);
	self->priv->_lsw_contact = _tmp1_;
	g_object_notify ((GObject *) self, "lsw-contact");

and the destructor frees it:

	__vala_SwContact_free0 (self->priv->_lsw_contact);
Comment 2 Philip Withnall 2013-03-13 09:38:35 UTC 
Review of attachment 238716 [details] [review]:

Looks good to me.
Comment 3 Simon McVittie 2013-03-13 12:59:07 UTC 
Comment on attachment 238716 [details] [review]
Don't do manual memory management for libsocialweb Contact  structs

89481c9dac3
Comment 4 Simon McVittie 2013-03-13 12:59:36 UTC 
Fixed in git for 0.9.2