After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695710 - Fails to build when only gdk and wayland backends are enabled
Fails to build when only gdk and wayland backends are enabled
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks: wayland
 
 
Reported: 2013-03-12 15:29 UTC by Emilio Pozuelo Monfort
Modified: 2013-04-29 07:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix GDK backend build when X11 support is disabled (960 bytes, patch)
2013-03-12 15:33 UTC, Emilio Pozuelo Monfort 		committed Details | Review

Description Emilio Pozuelo Monfort 2013-03-12 15:29:00 UTC 
I'm building clutter with:

./autogen.sh --prefix=/opt/wayland --enable-wayland-backend --enable-wayland-compositor

That gets me the gdk and wayland backends enabled and the x11 backend disabled:

 • Clutter Backends:
        Windowing systems: gdk wayland (WARNING: Experimental backends enabled)
        Input backends: gdk wayland

     - Wayland compositor support enabled (WARNING: Experimental)

With that setup, compiling fails with:

  CC     clutter-stage-gdk.lo
./gdk/clutter-stage-gdk.c: In function 'clutter_stage_gdk_realize':
./gdk/clutter-stage-gdk.c:271:49: error: 'clutter_stage_gdk_update_foreign_event_mask' undeclared (first use in this function)
./gdk/clutter-stage-gdk.c:271:49: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [clutter-stage-gdk.lo] Error 1

However if I also enable the x11 backend it doesn't fail. Seems to be a bad #if guard.
Comment 1 Emilio Pozuelo Monfort 2013-03-12 15:33:50 UTC 
Created attachment 238700 [details] [review]
Fix GDK backend build when X11 support is disabled

clutter_stage_gdk_update_foreign_event_mask is built when CLUTTER_WINDOWING_X11 is defined but used when GDK_WINDOWING_X11 is defined. Change that to build and use it when GDK_WINDOWING_X11 is defined.
Comment 2 Emilio Pozuelo Monfort 2013-03-12 15:34:26 UTC 
(component -> general as this is gdk and not wayland)
Comment 3 Daniel Narvaez 2013-04-27 23:52:16 UTC 
I can confirm the bug an that the patch makes it build for me. Any chance of a review?

This breaks the very nice instruction on

http://wayland.freedesktop.org/clutter.html

So it's a pity...
Comment 4 Emmanuele Bassi (:ebassi) 2013-04-28 00:17:23 UTC 
Review of attachment 238700 [details] [review]:

looks okay.