After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695685 - Add run-time checks for backend
Add run-time checks for backend
Status: RESOLVED FIXED
Product: clutter-gtk
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: clutter-gtk maintainer(s)
clutter-gtk maintainer(s)
Depends on:
Blocks: 672735
 
 
Reported: 2013-03-12 08:16 UTC by Bastien Nocera
Modified: 2013-03-13 16:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
util: Run-time check the backend used on init (1.73 KB, patch)
2013-03-12 23:39 UTC, Bastien Nocera
committed Details | Review
embed: Check whether we're running on X11 at run-time (2.47 KB, patch)
2013-03-13 14:38 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2013-03-12 08:16:19 UTC
(totem:4329): GLib-GObject-WARNING **: invalid cast from `GdkWaylandDisplay' to `GdkX11Display'

clutter-gtk should do run-time checks on the available clutter/gtk+ backends instead of assuming that because it's compiled against a particular backend, it is using that backend.
Comment 1 Emmanuele Bassi (:ebassi) 2013-03-12 13:12:39 UTC
we already do that, except for embedding GtkWidget inside GtkClutterActor, because we currently don't support anything except the texture_from_pixmap extension. obviously, there can be bugs in the support.

could you run with G_DEBUG=fatal-criticals and grab a stack trace?
Comment 2 Bastien Nocera 2013-03-12 23:39:39 UTC
Created attachment 238748 [details] [review]
util: Run-time check the backend used on init

Otherwise we could potentially try to run the GDK, X11 and
Wayland functions on startup.
Comment 3 Bastien Nocera 2013-03-13 14:38:03 UTC
Created attachment 238792 [details] [review]
embed: Check whether we're running on X11 at run-time

Rather than assuming a single backend.
Comment 4 Emmanuele Bassi (:ebassi) 2013-03-13 14:39:59 UTC
Review of attachment 238792 [details] [review]:

looks good.
Comment 5 Emmanuele Bassi (:ebassi) 2013-03-13 14:40:43 UTC
Review of attachment 238748 [details] [review]:

looks good.
Comment 6 Bastien Nocera 2013-03-13 16:29:56 UTC
Attachment 238748 [details] pushed as 8274daa - util: Run-time check the backend used on init
Attachment 238792 [details] pushed as c3807e2 - embed: Check whether we're running on X11 at run-time