GNOME Bugzilla – Bug 695673
status/keyboard: Translate IBus IME name if possible
Last modified: 2013-08-12 16:48:21 UTC
It would be nice if IBus IME names are translated as well as XKB layout names. The soon-to-be-released IBus 1.5.2 will have get_textdomain() method of IBusEngineDesc, which helps translate IME names in IME's own translation domain. See https://github.com/ibus/ibus/commit/42dd60fe
Created attachment 238657 [details] [review] status/keyboard: Translate IBus IME name if possible
Review of attachment 238657 [details] [review]: ::: js/ui/status/keyboard.js @@ +484,3 @@ + longName = Gettext.dgettext(textdomain, longName); + } + displayName = language + ' (' + longName + ')'; Not a new bug, but translating the name here makes it more obvious that foo + '(' + bar + ')' is not a proper way to construct a string to show in the UI - there should be a translatable template like "%s (%s)"
Created attachment 248823 [details] [review] status/keyboard: Translate IBus IME name if possible -- Use string.format() to construct display name, and also removed IBus API check as IBus 1.5.2 was released while ago. May I request to update the jhbuild module from 1.5.1 to 1.5.2?
Review of attachment 248823 [details] [review]: Looks good. Thanks
(In reply to comment #3) > May I request to update the jhbuild > module from 1.5.1 to 1.5.2? Anyone with commit access can do it, feel free to change it for the 3.10 moduleset.
Attachment 248823 [details] pushed as 974331b - status/keyboard: Translate IBus IME name if possible