GNOME Bugzilla – Bug 695668
phase timeout vs testing
Last modified: 2013-03-12 14:45:39 UTC
Created attachment 238647 [details] [review] Increase phase timeout The current ostree.gnome.org build server ends up using nested virtualization when running qemu for testing, and this is just too slow. Even when the build server is fixed, in theory other people could hit this, and we should try to work. Here are two different patches (that could as a third option be combined):
Created attachment 238648 [details] [review] Allow configuring phase timeout
Review of attachment 238648 [details] [review]: ::: gnome-session/gsm-manager.c @@ +2842,3 @@ + g_free (contents); +} + I can see why having this tweakable from the kernel commandline would be convenient to you, but I must say that I find this pretty horrible...
(In reply to comment #2) > Review of attachment 238648 [details] [review]: > > ::: gnome-session/gsm-manager.c > @@ +2842,3 @@ > + g_free (contents); > +} > + > > I can see why having this tweakable from the kernel commandline would be > convenient to you, but I must say that I find this pretty horrible... Yeah, I'm not a huge fan of the patch either. That's why there's a much simpler alternative patch here too =) But just for reference the /proc parsing came from https://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/power/gpm-common.c#n986
Review of attachment 238647 [details] [review]: Let's go with this one for now. The problem, I guess, is no matter what time we pick it's always going to be too short somewhere.
(In reply to comment #4) > Review of attachment 238647 [details] [review]: > > Let's go with this one for now. The problem, I guess, is no matter what time we > pick it's always going to be too short somewhere. Yeah, it's at least valuable though to match systemd I think. (I guess if we ever use systemd user sessions, that'll happen automatically).