After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695646 - [WK2] EphyShell tab load test fails
[WK2] EphyShell tab load test fails
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2013-03-11 18:29 UTC by Xan Lopez
Modified: 2013-03-13 08:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch 1/2 (13.78 KB, patch)
2013-03-12 13:39 UTC, Manuel Rego Casasnovas 		committed Details | Review
Patch 2/2 (9.89 KB, patch)
2013-03-12 13:40 UTC, Manuel Rego Casasnovas 		committed Details | Review

Description Xan Lopez 2013-03-11 18:29:26 UTC 
Same reason than the session tests probably:

  /src/ephy-shell/tab_load:                                            **
ERROR:../../tests/ephy-shell-test.c:157:test_ephy_shell_tab_load: assertion failed (ephy_web_view_get_address (view) == "ephy-about:overview"): ("about:blank" == "ephy-about:overview")
FAIL
Comment 1 Xan Lopez 2013-03-11 18:32:23 UTC 
Same for the tab load from external test:

  /src/ephy-shell/tab_from_external:                                   **
ERROR:../../tests/ephy-shell-test.c:278:test_ephy_shell_tab_from_external: assertion failed (ephy_web_view_get_address (ephy_embed_get_web_view (embed4)) == "ephy-about:applications"): ("about:blank" == "ephy-about:applications")
FAIL
Comment 2 Manuel Rego Casasnovas 2013-03-12 13:39:34 UTC 
Created attachment 238688 [details] [review]
Patch 1/2

This first patch move common code (currently only used in sessions tests) to ephy-test-utils.
Comment 3 Manuel Rego Casasnovas 2013-03-12 13:40:48 UTC 
Created attachment 238689 [details] [review]
Patch 2/2

This patch fixes the tests. It adds new methods in ephy-test-utils in order to ensure that a view has been loaded, but in this case not a new view, because of the test reuse the same view.
Comment 4 Xan Lopez 2013-03-12 20:01:07 UTC 
Review of attachment 238688 [details] [review]:

Perfect.
Comment 5 Xan Lopez 2013-03-12 20:04:50 UTC 
Review of attachment 238689 [details] [review]:

Also perfect!
Comment 6 Xan Lopez 2013-03-12 20:05:16 UTC 
Pushed both patches to master, closing.
Comment 7 Xan Lopez 2013-03-13 08:27:37 UTC 
Really closing.