After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695628 - assigns to VALAFLAGS which is reserved for the user
assigns to VALAFLAGS which is reserved for the user
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal minor
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-11 13:27 UTC by Simon McVittie
Modified: 2013-03-12 19:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not assign to VALAFLAGS (5.11 KB, patch)
2013-03-11 13:27 UTC, Simon McVittie 		accepted-commit_now Details | Review
Always append to AM_VALAFLAGS, don't replace (3.06 KB, patch)
2013-03-12 14:29 UTC, Simon McVittie 		accepted-commit_now Details | Review

Description Simon McVittie 2013-03-11 13:27:46 UTC 
Created attachment 238575 [details] [review]
Do not assign to VALAFLAGS

Users should be able to do "make VALAFLAGS=--enable-experimental-non-null"
without overriding necessary flags like --target-glib=2.24. The variable
for use by package maintainers is AM_VALAFLAGS.
Comment 1 Philip Withnall 2013-03-11 20:12:24 UTC 
Review of attachment 238575 [details] [review]:

Looks good. Again, this would all benefit from factoring out the common stuff in the build system into a couple of macros.
Comment 2 Philip Withnall 2013-03-11 20:13:47 UTC 
(In reply to comment #0)
> Users should be able to do "make VALAFLAGS=--enable-experimental-non-null"

Oh, also, would you mind briefly documenting this use case in HACKING? e.g. Something along the lines of “folks aims to compile with --enable-experimental-non-null in the future, so please try to reduce the number of warnings when compiling with that flag; do so by setting VALAFLAGS=--enable-experimental-non-null”.
Comment 3 Philip Withnall 2013-03-11 20:17:08 UTC 
(In reply to comment #2)
> Oh, also, would you mind briefly documenting this use case in HACKING?

Never mind, I just did it myself. Sorry for the noise.
Comment 4 Simon McVittie 2013-03-12 14:29:12 UTC 
Created attachment 238694 [details] [review]
Always append to AM_VALAFLAGS, don't replace

This avoids losing --target-glib=2.24 (from configure.ac) in certain
test modules.

---

Follow-up for Attachment #238575 [details].
Comment 5 Philip Withnall 2013-03-12 15:36:56 UTC 
Review of attachment 238694 [details] [review]:

Please commit.
Comment 6 Simon McVittie 2013-03-12 19:32:12 UTC 
Fixed in git for 0.9.2, NEWS also updated.