After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695607 - When switching input methods using the keyboard shortcut and the on-screen-display becomes too long, it becomes blank and unusable
When switching input methods using the keyboard shortcut and the on-screen-d...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-11 06:23 UTC by Mike FABIAN
Modified: 2013-03-14 21:43 UTC
See Also:
GNOME target: 3.8
GNOME version: ---


Attachments
switching-input-methods-osd.png (690.37 KB, image/png)
2013-03-11 06:23 UTC, Mike FABIAN
  Details
Screenshot (221.33 KB, image/png)
2013-03-13 09:13 UTC, Jasper St. Pierre (not reading bugmail)
  Details
st-scroll-view-fade: Don't use return in the shader (3.08 KB, patch)
2013-03-14 16:59 UTC, drago01
reviewed Details | Review
st-scroll-view-fade: Don't use return in the shader (3.35 KB, patch)
2013-03-14 21:39 UTC, drago01
committed Details | Review

Description Mike FABIAN 2013-03-11 06:23:17 UTC
Created attachment 238556 [details]
switching-input-methods-osd.png

Left screen shot: 
=================

7 input methods, just fits.
(Number of letters in the short name of the input method seems to be limited
to 3 unfortunately. The glyphs for the lower indices 1 and 2 for the two
Japanese input methods in that list are clipped at the top).


Right  screen shot:
===================

One more input method added.

The on screen display which pops up when changing input methods is empty
now. There is an arrow on the right side, sometimes an arrow on the left side
appears as well when some input method in the middle is selected, but one
never sees anything, it stays empty.
Comment 1 Matthias Clasen 2013-03-12 21:43:00 UTC
Rui, I think we should try to get this fixed for 3.8; looks pretty bad; and 7 is getting almost to a realistic number of input sources that one might have configured simultaneously.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-03-13 05:17:24 UTC
I can't reproduce. The scroll bars work for me.
Comment 3 Mathieu Bridon 2013-03-13 05:35:11 UTC
Could it be that Mike is testing in a VM?
Comment 4 Mike FABIAN 2013-03-13 08:26:31 UTC
(In reply to comment #2)
Jasper> I can't reproduce. The scroll bars work for me.

Scroll bars? You mean the small triangles at the left and the right side?
And is the on screen display not blank for you?
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-03-13 09:13:50 UTC
Created attachment 238765 [details]
Screenshot

As the screenshot shows, it works fine for me.
Comment 6 Matthias Clasen 2013-03-13 10:29:58 UTC
Maybe it is a question of screen resolution ? Mike whats yours ?
Comment 7 Matthias Clasen 2013-03-13 10:39:48 UTC
Indeed, it works ok for me as well, I have to add 8 input sources before the scrolling starts, but it works fine then.

Or maybe font or font size is relevant - I tried large text, it still worked fine.
Comment 8 Mike FABIAN 2013-03-13 10:57:53 UTC
(In reply to comment #6)
> Maybe it is a question of screen resolution ? Mike whats yours ?

1024x768
Comment 9 Mathieu Bridon 2013-03-13 11:11:32 UTC
I can reproduce it.

My screen resolution is 1280x1024.

However, like Mike I'm running in a VM.

Could this be a driver issue?
Comment 10 Mike FABIAN 2013-03-13 16:16:39 UTC
Rui says it looks like a driver issue because the VM uses software
rendering. He says it could be something mesa’s llvmpipe.

So mabe I should open a bug against mesa instead?
Comment 11 Mike FABIAN 2013-03-13 16:52:27 UTC
Ayax says:

<ajax> llvmpipe's rendering limits are only 2k wide i think, if clutter's
       creating a texture wider than that then it's not surprising (and not a
       mesa bug)
Comment 12 drago01 2013-03-14 16:59:48 UTC
Created attachment 238906 [details] [review]
st-scroll-view-fade: Don't use return in the shader

Returing from main() makes llvmpipe unhappy (produces black output color),
so rework the logic to avoid the return.
Comment 13 drago01 2013-03-14 17:45:22 UTC
Btw. this bug affects all scroll areas where we use fade (app picker, message tray banners with scrollbars, chats ...)
Comment 14 Jasper St. Pierre (not reading bugmail) 2013-03-14 21:15:23 UTC
Review of attachment 238906 [details] [review]:

Can you please use spaces, not tabs, for indentation? And can you add a link to an upstream llvmpipe bug for this?
Comment 15 drago01 2013-03-14 21:32:44 UTC
(In reply to comment #14)
> Review of attachment 238906 [details] [review]:
> 
> Can you please use spaces, not tabs, for indentation? 

Huh? Sorry this happens when you work inside a VM with nothing configured ...
Comment 16 drago01 2013-03-14 21:39:17 UTC
Created attachment 238936 [details] [review]
st-scroll-view-fade: Don't use return in the shader

Returing from main() makes llvmpipe unhappy (produces black output color),
so rework the logic to avoid the return.


---

Fixed indentation and added a comment with a bug reference.
Comment 17 Jasper St. Pierre (not reading bugmail) 2013-03-14 21:41:43 UTC
Review of attachment 238936 [details] [review]:

OK.
Comment 18 drago01 2013-03-14 21:43:31 UTC
Attachment 238936 [details] pushed as 45fc7ec - st-scroll-view-fade: Don't use return in the shader