After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695563 - The troughs look wrong
The troughs look wrong
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
3.7.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-10 13:35 UTC by Reda Lazri
Modified: 2013-04-09 20:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
before and after (1.05 KB, image/png)
2013-03-10 13:35 UTC, Reda Lazri
  Details
make to shading of trough lighter (900 bytes, patch)
2013-04-09 15:19 UTC, Jakub Steiner
none Details | Review

Description Reda Lazri 2013-03-10 13:35:59 UTC
Created attachment 238521 [details]
before and after

I actually showed this to Jimmac over IRC and he nodded(hopefully in agreement), but they're still not fixed in the SVG on 'gnome-mockups' and still look broken here. 
There is a dark 1px line that is the same color as the stroke, and it's making the trough look broken somehow. Please, check the attachment; my fix is the one on top.
Comment 1 Matthias Clasen 2013-03-11 03:47:19 UTC
before and after what ? no patch here...
Comment 2 Reda Lazri 2013-03-11 13:40:48 UTC
Sorry that was not a working code, it was the modified SVG for demonstration purposes only. I can send you the values if you want. :) 

It's gonna probably take ages for me to set up and familiarize myself with the structure of the theme and test and do it again for gtk2...Even after I submit the patch, it's going to be for 3.6 since I don't have 3.7 anymore.

It's more convenient time-wise for a theme dev to reduce the opacity and commit than for me to start from the very beginning. :P

I'll make myself useful on another occasion, I promise. :P
Comment 3 Jakub Steiner 2013-04-09 15:19:51 UTC
Created attachment 241070 [details] [review]
make to shading of trough lighter
Comment 4 Jakub Steiner 2013-04-09 15:20:43 UTC
Couldn't test this due to libffi build issues, but the above patch should address the issue.
Comment 5 Cosimo Cecchi 2013-04-09 19:50:09 UTC
Pushed a slightly more complex version, as the proposed patch didn't actually change the right colors.
Comment 6 Reda Lazri 2013-04-09 20:08:45 UTC
I think you forgot GTK2 and the dark variant. :)
Comment 7 Cosimo Cecchi 2013-04-09 20:29:59 UTC
Pushed fixes for those as well now :)
Comment 8 Reda Lazri 2013-04-09 20:41:57 UTC
Thank you!