GNOME Bugzilla – Bug 695536
Fix format and language chooser check marks being cleared
Last modified: 2013-03-18 12:12:05 UTC
Fallout from the "keeping things centered" patches.
Created attachment 238496 [details] [review] common: Fix language chooser check marks being cleared
Created attachment 238497 [details] [review] region: Fix format chooser check marks being cleared
Review of attachment 238496 [details] [review]: This code was a clever trick that I learned while working on this code: By clearing the image and setting its size, we can get the checkmark to disappear, but still reserve space for it, which keeps things from jumping around as we check and uncheck them. Now, with the centering, we probably need the opposite: make the checkmark appear without taking up any extra space that would disturb the centering.
Review of attachment 238496 [details] [review]: I'd rather the code didn't rely on clever tricks to be fair...
Review of attachment 238496 [details] [review]: The patch itself is correct though.
Review of attachment 238497 [details] [review]: Fine.
You'll need to check that this doesn't break the centering of the labels though.
(In reply to comment #7) > You'll need to check that this doesn't break the centering of the labels > though. It doesn't break the centering but it has the problem Matthias outlined above: it makes things jump sideways as you select them.
Created attachment 239000 [details] [review] region: Keep format chooser labels centered In order to prevent the labels from moving around when hiding and showing the check mark we need to keep the check mark always visible and instead tweak its opacity. We also add an always transparent widget the same size as the check mark on the other side of the label to make sure that the label is globally centered.
Created attachment 239001 [details] [review] common: Keep language chooser labels centered -- Took me a while to figure out a way to keep the labels centered. Finally came up with these dummy transparent check marks which isn't very elegant but works.
Attachment 238496 [details] pushed as 81e70ef - common: Fix language chooser check marks being cleared Attachment 238497 [details] pushed as 077dcf4 - region: Fix format chooser check marks being cleared Attachment 239000 [details] pushed as 1748a89 - region: Keep format chooser labels centered Attachment 239001 [details] pushed as fbc9e05 - common: Keep language chooser labels centered