After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695485 - Don't replace an already running prompter
Don't replace an already running prompter
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.6.x
Other Linux
: Normal major
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-09 10:09 UTC by Stef Walter
Modified: 2013-03-13 06:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyring: Don't replace an already running prompter (1.16 KB, patch)
2013-03-09 10:11 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2013-03-09 10:09:00 UTC 
If another keyring prompter races to startup before gnome-shell does, then don't replace that one. Otherwise this results in cancelled operations/prompts, and unexpected behavior during auto-login.

This does not fix the race between the fallback prompter and the shell prompter during startup (see bug# 693145), but makes prompting reliable.

Without this patch gnome-keyring-daemon does a critical warning that it's prompter is behaving in unexpected ways.
Comment 1 Stef Walter 2013-03-09 10:11:56 UTC 
Created attachment 238451 [details] [review]
keyring: Don't replace an already running prompter

 * Prompters have state, and cancelling an already prompter will
   cause prompts that are in progress to fail.
 * In addition allow replacement of our shell prompter for debugging
   purposes.
Comment 2 Matthias Clasen 2013-03-09 22:51:54 UTC 
Should we consider this for 3.8 ?
Comment 3 Stef Walter 2013-03-10 06:50:33 UTC 
Yes please. Downstreams may also want to consider it for 3.6.
Comment 4 Matthias Clasen 2013-03-11 03:41:08 UTC 
Florian, can you review this ?
Comment 5 Florian Müllner 2013-03-11 12:29:09 UTC 
Review of attachment 238451 [details] [review]:

Not a big fan - using the fallback prompter in one session and the shell one in another isn't exactly a nice user experience. So we still need to figure out how to prevent the o.g.k prompt to run in a shell session, but the patch at least makes our failure a bit nicer, so ...
Comment 6 Stef Walter 2013-03-13 06:57:09 UTC 
(In reply to comment #5)
> Review of attachment 238451 [details] [review]:
> 
> Not a big fan - using the fallback prompter in one session and the shell one in
> another isn't exactly a nice user experience. So we still need to figure out
> how to prevent the o.g.k prompt to run in a shell session, but the patch at
> least makes our failure a bit nicer, so ...

Yeah I agree, I'm not a big fan either. As noted, please comment at bug# 693145 if you have an plan for an easy way to do what you describe.
Comment 7 Stef Walter 2013-03-13 06:58:49 UTC 
Attachment 238451 [details] pushed as 805a409 - keyring: Don't replace an already running prompter