After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695471 - layout overflow in application view
layout overflow in application view
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-08 22:32 UTC by Colin Walters
Modified: 2013-03-11 12:34 UTC
See Also:
GNOME target: 3.8
GNOME version: ---


Attachments
screenshot (384.62 KB, image/png)
2013-03-08 22:32 UTC, Colin Walters
  Details
style: Prevent dash from overlapping content (1.26 KB, patch)
2013-03-09 00:00 UTC, Florian Müllner
committed Details | Review

Description Colin Walters 2013-03-08 22:32:46 UTC
Created attachment 238427 [details]
screenshot

Looks like a bug to me, but feel free to close if it's not.  

gnome-ostree current master,
gnome-shell git revision ef623cf
Comment 1 drago01 2013-03-08 23:12:19 UTC
(In reply to comment #0)
> Created an attachment (id=238427) [details]
> screenshot
> 
> Looks like a bug to me, but feel free to close if it's not.  

This is a bug.
Probably caused by the centering patches.
Comment 2 Florian Müllner 2013-03-08 23:18:38 UTC
(In reply to comment #1)
> This is a bug.
> Probably caused by the centering patches.

Yes. The dash is now in a separate layer on top of the view selector. This works fine on sufficiently wide monitors, as we end up with enough whitespace left and right of the content, but apparently fails for smaller sizes. The easiest fix is to set horizontal padding that matches the maximum dash width, but it has a drawback: as we take away space from the icon grid even if not necessary, we end up distributing less whitespace when doing the dynamic spacing ...
Comment 3 Florian Müllner 2013-03-09 00:00:59 UTC
Created attachment 238439 [details] [review]
style: Prevent dash from overlapping content

In order to center the view selector, the dash has been moved to a
separate layer, which means that it will overlap the app picker and
search results if the available width is smaller than the maximum
width that the content will request. Fix this by adding enough
horizontal padding to account for the width the dash will have at
its largest icon size.


As mentioned before, I'm not the biggest fan of this approach, but at least it works (so if we fail to come up with something better ...)
Comment 4 Matthias Clasen 2013-03-11 03:40:39 UTC
We should get this in for 3.8 - that screenshot looks really broken...
Comment 5 drago01 2013-03-11 09:38:17 UTC
Review of attachment 238439 [details] [review]:

I am not really a fan of this either but it is better then the current state.
We can still replace it with something better later.
Comment 6 Florian Müllner 2013-03-11 12:34:01 UTC
Attachment 238439 [details] pushed as 884af3c - style: Prevent dash from overlapping content