GNOME Bugzilla – Bug 695465
Add separators to lists
Last modified: 2013-03-18 10:01:48 UTC
I forgot to add separators as was in the mockups.
Created attachment 238413 [details] [review] common: Add separators to the language chooser list
Created attachment 238414 [details] [review] region: Add separators to the format chooser list
Created attachment 238415 [details] [review] region: Add separators to the input chooser list
Created attachment 238478 [details] Before - After
Review of attachment 238413 [details] [review]: Fine. Will need UI freeze break requests.
Review of attachment 238414 [details] [review]: Ditto.
Review of attachment 238415 [details] [review]: Looks fine otherwise. ::: panels/region/cc-input-chooser.c @@ +213,3 @@ + TRUE, + 1); /* FIXME: 0 should work but the separator + doesn't show up - theme issue? */ This needs fixing before committing.
(In reply to comment #7) > Review of attachment 238415 [details] [review]: > > Looks fine otherwise. > > ::: panels/region/cc-input-chooser.c > @@ +213,3 @@ > + TRUE, > + 1); /* FIXME: 0 should work but the separator > + doesn't show up - theme issue? */ > > This needs fixing before committing. It's fixed now: https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-8&id=549893c7d195a476eed7eb6aa907711bf1db43ad .
Got UI freeze break approval: https://mail.gnome.org/archives/release-team/2013-March/msg00125.html Attachment 238413 [details] pushed as 45b785a - common: Add separators to the language chooser list Attachment 238414 [details] pushed as 1407140 - region: Add separators to the format chooser list Attachment 238415 [details] pushed as 44d3c82 - region: Add separators to the input chooser list