After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695452 - Add a "new" action to the app menu
Add a "new" action to the app menu
Status: RESOLVED FIXED
Product: gnome-weather
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Weather Maintainer(s)
GNOME Weather Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-08 17:37 UTC by Paolo Borelli
Modified: 2013-03-09 11:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a "new" action to the app menu (4.18 KB, patch)
2013-03-08 17:37 UTC, Paolo Borelli
reviewed Details | Review

Description Paolo Borelli 2013-03-08 17:37:05 UTC
This way it is possible to use ctrl+N to show the dialog. It also
refactors the code to move the "about" action to the window, so that
we do not need to proxy it manually.
Comment 1 Paolo Borelli 2013-03-08 17:37:07 UTC
Created attachment 238385 [details] [review]
Add a "new" action to the app menu
Comment 2 Giovanni Campagna 2013-03-08 17:42:40 UTC
Review of attachment 238385 [details] [review]:

Nice improvement indeed.

::: data/app-menu.ui
@@ +6,3 @@
+        <attribute name="action">win.new</attribute>
+        <attribute name="accel">&lt;Primary&gt;n</attribute>
+      </item>

"New" should probably have its own section.
Comment 3 Paolo Borelli 2013-03-08 18:37:54 UTC
> 
> "New" should probably have its own section.

you are right... actually looking at clocks that was reviewed with Allan, we have

New
About
----
Quit
Comment 4 Giovanni Campagna 2013-03-08 21:37:29 UTC
Ah, if that's the design, it's fine by me.
Comment 5 Paolo Borelli 2013-03-09 11:25:34 UTC
I amended the patch for the sections stuff (and to remove a leftover) and pushed to 3-8 and master