After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695450 - Password dialog redesign
Password dialog redesign
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
3.10
Depends on: 689344
Blocks: 698957
 
 
Reported: 2013-03-08 16:21 UTC by Ondrej Holy
Modified: 2013-06-11 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
password dialog redesign (55.18 KB, patch)
2013-03-08 16:25 UTC, Ondrej Holy
none Details | Review
screenshot (140.38 KB, image/png)
2013-03-08 16:27 UTC, Ondrej Holy
  Details
screencast (169.68 KB, video/webm)
2013-04-05 13:23 UTC, Allan Day
  Details
password dialog redesign (57.42 KB, patch)
2013-04-05 15:05 UTC, Ondrej Holy
none Details | Review
password dialog redesign (57.16 KB, patch)
2013-04-11 12:58 UTC, Ondrej Holy
none Details | Review
password dialog redesign (58.91 KB, patch)
2013-06-06 14:26 UTC, Ondrej Holy
needs-work Details | Review
password dialog redesign (59.06 KB, patch)
2013-06-11 08:47 UTC, Ondrej Holy
committed Details | Review

Description Ondrej Holy 2013-03-08 16:21:34 UTC
The password dialog needs some design changes corresponding to an add user dialog redesign (Bug 689344).

There are proposed mockups:
https://raw.github.com/gnome-design-team/gnome-mockups/master/system-settings/users/user-accounts.png
https://raw.github.com/gnome-design-team/gnome-mockups/master/system-settings/users/add-user-account.png
Comment 1 Ondrej Holy 2013-03-08 16:25:00 UTC
Created attachment 238377 [details] [review]
password dialog redesign

Hint changes depends on Bug 689344.
Comment 2 Ondrej Holy 2013-03-08 16:27:32 UTC
Created attachment 238378 [details]
screenshot
Comment 3 Allan Day 2013-03-28 16:42:16 UTC
Looks good. A few issues:

 * You get some extreme (horizontal) window resizing when you enter a password into the field.

 * The strength meter text simply reads "Weak", "Fair" and so on. This is inconsistent with the new user dialog, which reads "Strength: Weak". They should be consistent.
Comment 4 Ondrej Holy 2013-03-29 09:03:56 UTC
(In reply to comment #3)
> Looks good. A few issues:
> 
>  * You get some extreme (horizontal) window resizing when you enter a password
> into the field.

Unfortunately I don't see any resizing at all. Do you have some specific settings of your system? Can you send me screencast (Control + Shift + Alt + R)? 

>  * The strength meter text simply reads "Weak", "Fair" and so on. This is
> inconsistent with the new user dialog, which reads "Strength: Weak". They
> should be consistent.

I fixed it before, however I haven't only reattached slightly modified patch after hints changes...
Comment 5 Allan Day 2013-04-05 13:23:47 UTC
Created attachment 240743 [details]
screencast

Here's a screencast of the resizing issue.
Comment 6 Ondrej Holy 2013-04-05 15:05:50 UTC
Created attachment 240756 [details] [review]
password dialog redesign

Changes in attached patch:
- Hint when passwords don't match.
- Hint updates with timeout.
- Don't show strength hint when empty password.
- Fix for hint label size.

Thank you for screencast. Can you check the resizing issue again, please?
Comment 7 Ondrej Holy 2013-04-11 12:58:06 UTC
Created attachment 241250 [details] [review]
password dialog redesign

Fix due to hint changes in Bug 689344 .
Comment 8 Ondrej Holy 2013-06-06 14:26:45 UTC
Created attachment 246163 [details] [review]
password dialog redesign

Several fixes:
- to be margeable to master
- request old password if user is privileged also
Comment 9 Thomas Wood 2013-06-06 16:15:37 UTC
Review of attachment 246163 [details] [review]:

There is one minor issue where when you type a new password and confirm it, then choose to set the password at next login, the confirm new password box is left sensitive, rather than being made insensitive.

::: panels/user-accounts/um-password-dialog.c
@@ +311,1 @@
         return FALSE;

The source is removed by returning FALSE, so um->password_entry_timeout_id needs to be set to 0.

@@ +390,3 @@
         }
 
         return FALSE;

For the same reason as above, um->old_password_entry_timeout_id needs to be set to 0 here.
Comment 10 Ondrej Holy 2013-06-11 08:47:28 UTC
Created attachment 246489 [details] [review]
password dialog redesign

Thank you for review. Confirmation box issue fixed, time source issue fixed.
Comment 11 Thomas Wood 2013-06-11 14:30:38 UTC
Patch pushed to master.