GNOME Bugzilla – Bug 695450
Password dialog redesign
Last modified: 2013-06-11 14:30:42 UTC
The password dialog needs some design changes corresponding to an add user dialog redesign (Bug 689344). There are proposed mockups: https://raw.github.com/gnome-design-team/gnome-mockups/master/system-settings/users/user-accounts.png https://raw.github.com/gnome-design-team/gnome-mockups/master/system-settings/users/add-user-account.png
Created attachment 238377 [details] [review] password dialog redesign Hint changes depends on Bug 689344.
Created attachment 238378 [details] screenshot
Looks good. A few issues: * You get some extreme (horizontal) window resizing when you enter a password into the field. * The strength meter text simply reads "Weak", "Fair" and so on. This is inconsistent with the new user dialog, which reads "Strength: Weak". They should be consistent.
(In reply to comment #3) > Looks good. A few issues: > > * You get some extreme (horizontal) window resizing when you enter a password > into the field. Unfortunately I don't see any resizing at all. Do you have some specific settings of your system? Can you send me screencast (Control + Shift + Alt + R)? > * The strength meter text simply reads "Weak", "Fair" and so on. This is > inconsistent with the new user dialog, which reads "Strength: Weak". They > should be consistent. I fixed it before, however I haven't only reattached slightly modified patch after hints changes...
Created attachment 240743 [details] screencast Here's a screencast of the resizing issue.
Created attachment 240756 [details] [review] password dialog redesign Changes in attached patch: - Hint when passwords don't match. - Hint updates with timeout. - Don't show strength hint when empty password. - Fix for hint label size. Thank you for screencast. Can you check the resizing issue again, please?
Created attachment 241250 [details] [review] password dialog redesign Fix due to hint changes in Bug 689344 .
Created attachment 246163 [details] [review] password dialog redesign Several fixes: - to be margeable to master - request old password if user is privileged also
Review of attachment 246163 [details] [review]: There is one minor issue where when you type a new password and confirm it, then choose to set the password at next login, the confirm new password box is left sensitive, rather than being made insensitive. ::: panels/user-accounts/um-password-dialog.c @@ +311,1 @@ return FALSE; The source is removed by returning FALSE, so um->password_entry_timeout_id needs to be set to 0. @@ +390,3 @@ } return FALSE; For the same reason as above, um->old_password_entry_timeout_id needs to be set to 0 here.
Created attachment 246489 [details] [review] password dialog redesign Thank you for review. Confirmation box issue fixed, time source issue fixed.
Patch pushed to master.