Created attachment 238354 [details]
GnuCash investment account data file template

This is a confirmation that the patch shown below, written by Bill Burke, corrects a current bug in all versions of GnuCash. I strongly recommend that this patch be incorporated into the next release, as it remedies a number of previously mentioned issues, i.e. Bugzilla #98963, 237744, 606607 and (I think) 491174. I have installed this patch and it works well.

Index: src/import-export/ofx/gnc-ofx-import.c
===================================================================
--- src/import-export/ofx/gnc-ofx-import.c	(revision 18973)
+++ src/import-export/ofx/gnc-ofx-import.c	(working copy)
@@ -109,7 +109,7 @@
     kvp_frame * acc_frame;
     kvp_value * kvp_val;
     const GncGUID * income_acc_guid;
-    gchar *investment_account_text;
+    gchar *investment_account_text, *investment_account_onlineid;
     gnc_commodity *currency = NULL;
     gnc_commodity *investment_commodity = NULL;
     gnc_numeric gnc_amount, gnc_units;
@@ -418,8 +418,10 @@
                                                                  in any
translations.  */
                                                       _("Stock account
for security \"%s\""),

data.security_data_ptr->secname);
+                       investment_account_onlineid =
g_strdup_printf( "%s%s", data.account_id, data.unique_id);
+
                         investment_account =
gnc_import_select_account(NULL,
-                                             data.unique_id,
+
investment_account_onlineid,
                                              1,
                                              investment_account_text,
                                              investment_commodity,
@@ -427,6 +429,7 @@
                                              NULL,
                                              NULL);
                         g_free (investment_account_text);
+                       g_free (investment_account_onlineid);
                         investment_account_text = NULL;
                         if (investment_account != NULL &&
                                 data.unitprice_valid == true &&

Description:

From Bill Burke's description in his gnucash-devel email (https://lists.gnucash.org/pipermail/gnucash-devel/2010-March/027932.html): This patch allows the same commodity to be held in different accounts. Currently, only one account may be associated with a specific commodity. This patch adds the account_online_id as well to differentiate between commodities held in different accounts.

Steps to reproduce the bug:

A. Create and set up a new GnuCash data file. You may use the following procedure to set up the new file from scratch. Alternatively, you may use the attached sample file "InvestTemplate.gnucash" and forego the following 4 steps:
  1.  Using the "New Account Hierarchy setup" druid, select "Retirement" and "Spouse Retirement" accounts;
  2.  Edit the "Mutual Fund" commodity account in the "Retirement" asset account and create a new mutual fund called "Vanguard 500 Index Fund Admiral" with the ticker symbol "VFINX";
  3.  Repeat Step 2 for "Mutual Fund" in "Spouse Retirement" account;
  4.  Name the new GnuCash data file "InvestTemplate" and save the file;

Note: We now have a new GnuCash file named "InvestTemplate.gnucash" containing 2 unique investment accounts, with the mutual fund VFINX in each. We will now attempt to import three separate purchases of VFINX mutual fund, one purchase to the "Retirement" account and two purchases to the "Spouse Retirement" account using the File->Import->OFX/QFX Import utility. We will now import the three attached OFX files. First steps (A through C) relate to the current versions of GnuCash. The later steps relate to GnuCash after the Burke patch is applied.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Procedure prior to applying Burke patch using standard GnuCash distribution --

A. Import "OfxDownload(1).ofx" to purchase 0.74 VFINX shares in Assets:Investments:Retirement account on 4 Jan 2013
  1.  Open a new "InvestTemplate.gnucash" file
  2.  Click File->Import->Import OFX/QFX...
  3.  At "Select an OFX/QFX File to Process" dialog, choose "OfxDownload(1).ofx" and click the "Import" button
  4.  At "Select Security/Currency" dialog, choose "Type" = FUND and "Security/Currency" = VFINX and click OK
  5.  At "Select Account" dialog, choose "Assets:Investments:Retirement" to associate account "vanguard.com 01234567890" with "Retirement" bank account and click OK
  6.  At "Select Account" dialog, choose "Assets:Investments:Retirement:Mutual Fund" to associate "Mutual Fund" with the security "Vanguard 500 Index Fund Investor (full account ID: vanguard.com 922908108)" and click OK
  7.  At "Generic Import Transaction Matcher" dialog, click OK to import the downloaded transaction as listed.

Note: We now have 0.74 VFINX shares in Assets:Investments:Retirement:Mutual Fund and a negative $100.00 balance in Assets:Investments:Retirement, which is correct.

B. Import "OfxDownload(2).ofx" to purchase 0.74 VFINX shares in Assets:Investments:Spouse Retirement account on 4 Jan 2013
  1.  Click File->Import->Import OFX/QFX...
  2.  At "Select an OFX/QFX File to Process" dialog, choose "OfxDownload(2).ofx" and click the "Import" button
  3.  At "Select Account" dialog, choose "Assets:Investments:Spouse Retirement" to associate account "vanguard.com 34567890123" with "Spouse Retirement" bank account and click OK
  4.  At "Generic Import Transaction Matcher" dialog, click the "A" checkbox and click OK to import the downloaded transaction as listed.

Note: We now have 1.48 VFINX shares in Assets:Investments:Retirement:Mutual Fund, a negative $100.00 balance in Assets:Investments:Retirement and a negative $100.00 balance in Assets:Investments:Spouse Retirement. This transaction import processed the "OfxDownload(2).ofx" file incorrectly.

C. Import "OfxDownload(3).ofx" to purchase an additional 0.74 VFINX shares in Assets:Investments:Spouse Retirement:Mutual Fund account on 14 Jan 2013
  1.  Click File->Import->Import OFX/QFX...
  2.  At "Select an OFX/QFX File to Process" dialog, choose "OfxDownload(3).ofx" and click the "Import" button
  3.  At "Generic Import Transaction Matcher" dialog, click the "A" checkbox and click OK to import the downloaded transaction as listed.

Note: We now have 2.22 VFINX shares in Assets:Investments:Retirement:Mutual Fund, a negative $100.00 balance in Assets:Investments:Retirement and a negative $200.00 balance in Assets:Investments:Spouse Retirement. This transaction import processed the "OfxDownload(3).ofx" file incorrectly.

Actual results:

The first import correctly associated the purchase of 0.74 VFINX shares with "Assets:Investments:Retirement:Mutual Fund", but the second and third imports incorrectly associated the purchase of 1.48 VFINX shares with "Assets:Investments:Retirement:Mutual Fund" also. As you can see, the end result is three identical purchase transactions in "Assets:Investments:Retirement:Mutual Fund", whereas we should have one purchase transaction in "Assets:Investments:Retirement:Mutual Fund" and two purchase transactions in "Assets:Investments:Spouse Retirement:Mutual Fund." This is the crux of this bug - once a security is associated with an account, all transactions involving this security associate by default to that specific account.

Expected results:

The last two transaction imports should have been associated with the "Assets:Investments:SPOUSE RETIREMENT:Mutual Fund" account.  

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Procedure AFTER modifying gnu-ofx-import.c with the Burke patch. Most everyone would expect GnuCash to import the OFX files as shown below --

A. Import "OfxDownload(1).ofx" to purchase 0.74 VFINX shares in Assets:Investments:Retirement account on 4 Jan 2013
  1.  Open a new, "InvestTemplate.gnucash" file
  2.  Click File->Import->Import OFX/QFX...
  3.  At "Select an OFX/QFX File to Process" dialog, choose "OfxDownload(1).ofx" and click the "Import" button
  4.  At "Select Security/Currency" dialog, choose "Type" = FUND and "Security/Currency" = VFINX and click OK
  5.  At "Select Account" dialog, choose "Assets:Investments:Retirement" to associate account "vanguard.com 01234567890" with "Retirement" bank account and click OK
  6.  At "Select Account" dialog, choose "Assets:Investments:Retirement:Mutual Fund" to associate "Mutual Fund" with the security "Vanguard 500 Index Fund Investor (full account ID: vanguard.com 01234567890922908108)" and click OK
  7.  At "Generic Import Transaction Matcher" dialog, click OK to import the downloaded transaction as listed.

Note: We now have 0.74 VFINX shares in Assets:Investments:Retirement:Mutual Fund and a negative $100.00 balance in Assets:Investments:Retirement, which is correct.

B. Import "OfxDownload(2).ofx" to purchase 0.74 VFINX shares in Assets:Investments:Spouse Retirement account on 4 Jan 2013
  1.  Click File->Import->Import OFX/QFX...
  2.  At "Select an OFX/QFX File to Process" dialog, choose "OfxDownload(2).ofx" and click the "Import" button
  3.  At "Select Account" dialog, choose "Assets:Investments:Spouse Retirement" to associate account "vanguard.com 34567890123" with "Spouse Retirement" bank account and click OK
  4.  At "Select Account" dialog, choose "Assets:Investments:Spouse Retirement:Mutual Fund" to associate "Mutual Fund" with the security "Vanguard 500 Index Fund Investor (full account ID: vanguard.com 34567890123922908108)" and click OK
  5.  At "Generic Import Transaction Matcher" dialog, click OK to import the downloaded transaction as listed.

Note: We now have 0.74 VFINX shares in Assets:Investments:Retirement:Mutual Fund, 0.74 VFINX shares in Assets:Investments:Spouse Retirement:Mutual Fund and a negative $100.00 balance in each respective Assets:Investments account, which is correct.

C. Import "OfxDownload(3).ofx" to purchase an additional 0.74 VFINX shares in Assets:Investments:Spouse Retirement:Mutual Fund account on 14 Jan 2013
  1.  Click File->Import->Import OFX/QFX...
  2.  At "Select an OFX/QFX File to Process" dialog, choose "OfxDownload(3).ofx" and click the "Import" button
  3.  At "Generic Import Transaction Matcher" dialog, click the "A" checkbox and click OK to import the downloaded transaction as listed.

Actual results: We now have 0.74 VFINX shares in Assets:Investments:Retirement:Mutual Fund, 1.48 VFINX shares in Assets:Investments:Spouse Retirement:Mutual Fund, a negative $100.00 balance in Assets:Investments:Retirement and a negative $200.00 balance in Assets:Investments:Spouse Retirement, all of which is correct.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Does this happen every time?
Yes

Other information:
Ubuntu 10.04
GnuCash 2.4.11 from r22264M build
AqBanking 5.0.25
Gwenhywfar 4.3.3

Thank you.