GNOME Bugzilla – Bug 695414
Last modified: 2013-03-07 23:16:41 UTC
Created attachment 238348 [details] [review]
Subject: [PATCH] Add --disable-fallback-greeter configure option
This pairs with the above commit; it allows operating system
builders to entirely disable the fallback greeter, and rely
on software GL.
At the moment we keep this a configure option since some consumers of
GDM are using the fallback greeter.
configure.ac | 5 +++++
data/Makefile.am | 10 ++++++++--
data/gdm-shell-with-fallback.session.in | 5 +++++
data/gdm-shell.session.in | 2 --
4 files changed, 18 insertions(+), 4 deletions(-)
create mode 100644 data/gdm-shell-with-fallback.session.in
Testing this now for gnome-ostree in nested virt; I think this will help a lot with the smoketest woes, since it very consistently hits the fallback greeter, but that's not what I want.
Review of attachment 238348 [details] [review]:
oh awesome. one thing i can erase from my whiteboard! does distcheck still work?
@@ +295,3 @@
+ [Enable fallback greeter @<:@default=yes@:>@]),,
default should be no
(In reply to comment #2)
> Review of attachment 238348 [details] [review]:
> does distcheck still work?
I don't believe in distcheck myself, but I did fix one bug in the patch that would break it (adding the new file to EXTRA_DIST).
> ::: configure.ac
> @@ +295,3 @@
> + AS_HELP_STRING([--enable-fallback-greeter],
> + [Enable fallback greeter @<:@default=yes@:>@]),,
> + enable_fallback_greeter=yes)
> default should be no
Created attachment 238349 [details] [review]
Ok since previous was ACN, let's go with this.