After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695407 - Clicking attribution link in sidebar should load current city
Clicking attribution link in sidebar should load current city
Status: RESOLVED OBSOLETE
Product: libgweather
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-07 21:45 UTC by William Jon McCann
Modified: 2021-06-09 21:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
yr.no backend: include the right link to the new style attribution label (3.73 KB, patch)
2013-03-09 00:15 UTC, Giovanni Campagna 		needs-work Details | Review

Description William Jon McCann 2013-03-07 21:45:23 UTC 
Clicking the attribution link in sidebar should load the forecast page for the current city.
Comment 1 Giovanni Campagna 2013-03-09 00:15:03 UTC 
Created attachment 238440 [details] [review]
yr.no backend: include the right link to the new style attribution label

Instead of a link to the home page, build a link using the data in our
database, in the same format as the old style API.

Needs a string break, because the URL was previous embedded directly.
Comment 2 Giovanni Campagna 2013-03-09 00:16:06 UTC 
Btw, reassigning to libgweather, where the fix lives.
Comment 3 Bastien Nocera 2017-12-01 13:39:55 UTC 
Comment on attachment 238440 [details] [review]
yr.no backend: include the right link to the new style attribution label

The patch doesn't apply any more, but should be easy enough to update.

I'll also note that gnome-clocks doesn't have anywhere to show attribution either!
Comment 4 Giovanni Campagna 2017-12-01 17:18:53 UTC 
Nowadays gnome-weather shows attribution in the about page, which is not tied to the specific city shown, so this is less important.

Also, gnome-clocks should not need to show attribution, and AFAIR it disables Yr.no anyway to avoid network.
Comment 5 GNOME Infrastructure Team 2021-06-09 21:05:54 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libgweather/-/issues/118.