After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695389 - window-list: Fix new windows not being added to the list
window-list: Fix new windows not being added to the list
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-07 19:39 UTC by Florian Müllner
Modified: 2013-03-08 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window-list: connect_after() to 'window-added' (1.58 KB, patch)
2013-03-07 19:39 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2013-03-07 19:39:41 UTC
Fallout from always using application icons, see patch.
Comment 1 Florian Müllner 2013-03-07 19:39:44 UTC
Created attachment 238334 [details] [review]
window-list: connect_after() to 'window-added'

We switched from using the window icon to using the associated
application's icon; however when we create the window list item
from a handler to the 'window-added' signal, the association of
window and application might not exist yet, as WindowTracker uses
the same signal to create the association. Use connect_after()
for creating the window list item to make sure that WindowTracker's
signal handler has run already.
Comment 2 Giovanni Campagna 2013-03-07 21:28:46 UTC
Review of attachment 238334 [details] [review]:

Ok, but for example in auto-move-windows, which does something similar, I had to add an idle callback because get_window_app() was returning null despite connect_after(). We might have to do the same here.
Comment 3 Florian Müllner 2013-03-08 13:41:21 UTC
Attachment 238334 [details] pushed as 0bd8966 - window-list: connect_after() to 'window-added'

(In reply to comment #2)
> Ok, but for example in auto-move-windows, which does something similar, I had
> to add an idle callback because get_window_app() was returning null despite
> connect_after(). We might have to do the same here.

Ugh. That's a bit ugly, so I'd like to only go there if we have to, so pushing for now (if we encounter cases where this is not enough, maybe we should add some API to WindowTracker)