GNOME Bugzilla – Bug 695389
window-list: Fix new windows not being added to the list
Last modified: 2013-03-08 13:41:25 UTC
Fallout from always using application icons, see patch.
Created attachment 238334 [details] [review] window-list: connect_after() to 'window-added' We switched from using the window icon to using the associated application's icon; however when we create the window list item from a handler to the 'window-added' signal, the association of window and application might not exist yet, as WindowTracker uses the same signal to create the association. Use connect_after() for creating the window list item to make sure that WindowTracker's signal handler has run already.
Review of attachment 238334 [details] [review]: Ok, but for example in auto-move-windows, which does something similar, I had to add an idle callback because get_window_app() was returning null despite connect_after(). We might have to do the same here.
Attachment 238334 [details] pushed as 0bd8966 - window-list: connect_after() to 'window-added' (In reply to comment #2) > Ok, but for example in auto-move-windows, which does something similar, I had > to add an idle callback because get_window_app() was returning null despite > connect_after(). We might have to do the same here. Ugh. That's a bit ugly, so I'd like to only go there if we have to, so pushing for now (if we encounter cases where this is not enough, maybe we should add some API to WindowTracker)