After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695367 - Some UI fixes
Some UI fixes
Status: RESOLVED FIXED
Product: gnome-weather
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Weather Maintainer(s)
GNOME Weather Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-07 15:44 UTC by Cosimo Cecchi
Modified: 2013-03-07 16:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: remove unused code (891 bytes, patch)
2013-03-07 15:44 UTC, Cosimo Cecchi 		committed Details | Review
window: use header subtitle for the country name (2.27 KB, patch)
2013-03-07 15:45 UTC, Cosimo Cecchi 		committed Details | Review
window: don't clear info page whrn going back (852 bytes, patch)
2013-03-07 15:45 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-03-07 15:44:56 UTC 
See attached patches
Comment 1 Cosimo Cecchi 2013-03-07 15:44:58 UTC 
Created attachment 238309 [details] [review]
window: remove unused code
Comment 2 Cosimo Cecchi 2013-03-07 15:45:01 UTC 
Created attachment 238310 [details] [review]
window: use header subtitle for the country name
Comment 3 Cosimo Cecchi 2013-03-07 15:45:04 UTC 
Created attachment 238311 [details] [review]
window: don't clear info page whrn going back

We already clear it when setting a new location, and doing so breaks
crossfade animation back to the overview, since widgets are being
destroyed before the transition starts.
Comment 4 Giovanni Campagna 2013-03-07 16:06:26 UTC 
Review of attachment 238309 [details] [review]:

Uh, yes.
Comment 5 Giovanni Campagna 2013-03-07 16:08:03 UTC 
Review of attachment 238310 [details] [review]:

Ok.
Comment 6 Giovanni Campagna 2013-03-07 16:08:27 UTC 
Review of attachment 238311 [details] [review]:

Ok
Comment 7 Cosimo Cecchi 2013-03-07 16:21:11 UTC 
Thanks, pushed!