After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695363 - Register to Treeview - Sort and Filter
Register to Treeview - Sort and Filter
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Register
2.5.x
Other Linux
: Normal enhancement
: ---
Assigned To: Christian Stimming
Geert Janssens
Depends on:
Blocks: 673193
 
 
Reported: 2013-03-07 14:52 UTC by Bob
Modified: 2018-06-29 23:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Register rewrite patch (230.98 KB, patch)
2013-03-07 14:52 UTC, Bob
committed Details | Review

Description Bob 2013-03-07 14:52:45 UTC
Created attachment 238307 [details] [review]
Register rewrite patch

This is an update to the Possible Register migration to Treeview - 673193

As before, do not open same account register in old style and the tree-view one
and it may also be required to delete the saved pages in gconf under register2
heading.

This patch changes the register sort option to using a Model sort and the filter option to a Model filter. Sort details are now saved in gconf but the filter details are still stored in the account kvp.

It all looks to work but may need some tweaking. One thing I was thinking about was to blank the balance column when not in date order ?

There are some other minor changes in the patch that deal with cut, copy and paste of transactions and the auto complete of the blank transaction.

Two things I know that do not work are, Duplicate and reversing a transaction.
Comment 1 Geert Janssens 2013-03-11 18:20:37 UTC
Comment on attachment 238307 [details] [review]
Register rewrite patch

Applied as r22827, thank you very much.

A few notes:
- when applying git complained about whitespace errors. I have chosen to fix the whitespace errors while applying. As a result your local git update may have trouble because the commit in the central repository is now no longer the same as your local commit. It may be smart enough to discover the whitespace errors and skip over those, I'm not sure.

By the way: white space errors are any form of trailing white space on any line (including empty lines), or lines beginning with mixed tabs and spaces. I don't know which editor you use to write your code, but perhaps it has an option to prevent saving such whitespace errors.

- I have slightly rearranged your commit message into this structure:
<short summary line>
<longer description>
<Author line>

Keeping a short summary line separate from the rest is very handy for people receiving the commit mails. Only the first line is repeated in these mails.

- I love your use of GtkTreeView's filter and sort models. Great job !
Comment 2 John Ralls 2018-06-29 23:14:06 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=695363. Please update any external references or bookmarks.