After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695356 - new style if for warnings
new style if for warnings
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
git master
Other All
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-07 13:31 UTC by Carnë Draug
Modified: 2013-03-09 20:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add style id="warning" (4.17 KB, patch)
2013-03-07 13:33 UTC, Carnë Draug 		none Details | Review

Description Carnë Draug 2013-03-07 13:31:43 UTC 
After talking with nacho on IRC...

This adds a new style to highlight warnings on the def.lang. This is in addition to def:error, for things that may be errors but we can't know for sure. I have added to it to the other styles and tried to make it like error, but a bit lighter. I'm not a designer though, my general idea was to pick the error style and tune it down a bit.

The main reason behind this is bug #691757. The latex plugin sets its own warning and error style. The problem with this is that it does not respect the style set by the user and its warning sensor has a couple of bugs that make it overly sensitive. I do not know for what style file it was originally designed for, but makes warnings and errors pretty much impossible to read and edit when using the oblivion style (see attachment of bug #691757 with id=238281).
Comment 1 Carnë Draug 2013-03-07 13:33:23 UTC 
Created attachment 238290 [details] [review]
add style id="warning"
Comment 2 Carnë Draug 2013-03-09 20:59:59 UTC 
Patch pushed after approval by pbor on IRC.