After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695350 - gnome-xkb-info: Don't store duplicated layouts in locale tables
gnome-xkb-info: Don't store duplicated layouts in locale tables
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-07 10:56 UTC by Rui Matos
Modified: 2013-03-14 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-xkb-info: Don't store duplicated layouts in locale tables (1.95 KB, patch)
2013-03-07 10:56 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-03-07 10:56:20 UTC 
The fix in commit b3e4aef wasn't totally correct.
Comment 1 Rui Matos 2013-03-07 10:56:22 UTC 
Created attachment 238277 [details] [review]
gnome-xkb-info: Don't store duplicated layouts in locale tables

We can't store duplicated layouts anywhere since those get destroyed
when the 'layout' element ends and we'd end up with invalid entries
potentially leading to crashes when used.

Just doing a g_hash_table_remove() on the layouts_by_* tables was a
thinko and could never work since those only contain other tables as
values and it's in this second level tables that the layouts are
stored.
Comment 2 Bastien Nocera 2013-03-12 16:57:13 UTC 
Review of attachment 238277 [details] [review]:

Sure.
Comment 3 Rui Matos 2013-03-14 13:29:35 UTC 
Attachment 238277 [details] pushed as 886a568 - gnome-xkb-info: Don't store duplicated layouts in locale tables