After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695347 - Port to wk2 webview's snapshotting API
Port to wk2 webview's snapshotting API
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2013-03-07 10:07 UTC by Claudio Saavedra
Modified: 2013-03-11 21:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port to wk2 webview's snapshotting API (6.18 KB, patch)
2013-03-07 10:07 UTC, Claudio Saavedra 		committed Details | Review

Description Claudio Saavedra 2013-03-07 10:07:00 UTC 
This depends on the patch that is in https://bugs.webkit.org/show_bug.cgi?id=98270
Comment 1 Claudio Saavedra 2013-03-07 10:07:02 UTC 
Created attachment 238276 [details] [review]
Port to wk2 webview's snapshotting API
Comment 2 Xan Lopez 2013-03-07 10:22:36 UTC 
Review of attachment 238276 [details] [review]:

Looks sane to me. Probably add a FIXME about the fact that ideally EphyWebView should use the snapshot service instead of duplicating code.

::: embed/ephy-web-view.c
@@ +2167,3 @@
+      if (priv->snapshot_idle_id)
+        g_source_remove (priv->snapshot_idle_id);
+      priv->snapshot_idle_id = g_idle_add_full (G_PRIORITY_LOW, (GSourceFunc) web_view_check_snapshot, web_view, NULL);

No space in the cast.
Comment 3 Claudio Saavedra 2013-03-11 21:14:50 UTC 
Attachment 238276 [details] pushed as 628831d - Port to wk2 webview's snapshotting API