GNOME Bugzilla – Bug 695335
Driver download blocks media menu
Last modified: 2016-03-31 13:22:07 UTC
Driver (pre-)download happens during listing of user's media in wizard's menu. While its good to be nice to user and save his/her time during preparation step by pre-downloading all drivers, there is no reason to block population of media menu for achieving that. I'm working on solution for this bug, stay tuned!
(In reply to comment #0) > Driver (pre-)download happens during listing of user's media in wizard's menu. When was this predownload added? Is that a fallout of bug #694428?
Created attachment 238324 [details] [review] installer: Don't automatically download drivers for all media With this patch, we no longer start to download drivers as part of UnattendedInstaller construction but rather do it as part of a new general InstallerMedia.prepare method that is called as part of wizard's 'preparation' stage. The reason for this change is that us automatically downloading all drivers for all ISOs/medias users have, could easily congest a slow network. So now we only download drivers for a media/OS when users create their first VM against the media/OS in question. This also fixes the issue of population of wizard's media menu getting blocked by driver downloads.
Created attachment 238325 [details] [review] installer: Drop now redundant async declarations Some of the methods no longer do any async stuff so no need for them to be async. Declaring a sync method as async only complicates things for caller for no benefit.
Review of attachment 238324 [details] [review]: looks ok
Review of attachment 238325 [details] [review]: ack
Attachment 238324 [details] pushed as 5236c82 - installer: Don't automatically download drivers for all media Attachment 238325 [details] pushed as 65b1f0d - installer: Drop now redundant async declarations