After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695315 - Add make targets to have valgrinded tests be tortured or run forever...
Add make targets to have valgrinded tests be tortured or run forever...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
git master
Other Linux
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-06 19:13 UTC by Sebastian Rasmussen
Modified: 2013-03-07 00:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch for supporting valgrind all tests forever. (1.35 KB, patch)
2013-03-06 19:15 UTC, Sebastian Rasmussen
committed Details | Review
Proposed patch for supporting torturing tests inside valgrind. (2.56 KB, patch)
2013-03-06 19:15 UTC, Sebastian Rasmussen
committed Details | Review
Proposed patch for making torturing iterations configurable. (661 bytes, patch)
2013-03-06 19:16 UTC, Sebastian Rasmussen
committed Details | Review

Description Sebastian Rasmussen 2013-03-06 19:13:31 UTC
Right now make targets for the following is missing:

* torturing all tests inside valgrind
* run all tests in a loop inside valgrind forever
* torturing a specific test inside valgrind

Moreover it is not possible to control the number of iterations run when torturing.

The attached patches adds make targets for these tests and allows the LOOPS variable to be set. I have successfully tested this for some tests in gstreamer core.

PS. is the past tense of valgrinding really valgrinded or is it perhaps valground?
Comment 1 Sebastian Rasmussen 2013-03-06 19:15:22 UTC
Created attachment 238232 [details] [review]
Proposed patch for supporting valgrind all tests forever.
Comment 2 Sebastian Rasmussen 2013-03-06 19:15:56 UTC
Created attachment 238233 [details] [review]
Proposed patch for supporting torturing tests inside valgrind.
Comment 3 Sebastian Rasmussen 2013-03-06 19:16:40 UTC
Created attachment 238234 [details] [review]
Proposed patch for making torturing iterations configurable.
Comment 4 Tim-Philipp Müller 2013-03-07 00:16:19 UTC
Thanks, pushed:


commit a927a1d0d10118834b57a2c24d57874c10f67c10
Author: Sebastian Rasmussen <sebrn@axis.com>
Date:   Wed Feb 27 23:59:05 2013 +0100

    check.mak: Make number of torture iterations configurable
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=695315

commit 9bc83f2542b6366c241e0d9d7cb6a14fc536bde8
Author: Sebastian Rasmussen <sebrn@axis.com>
Date:   Wed Mar 6 19:50:58 2013 +0100

    check.mak: Add target for torturing tests inside valgrind
    
    Allows for testing either individual tests or all tests repeatedly.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=695315

commit 622377f6cf05c3bf00674aa5ee380a72278e7500
Author: Sebastian Rasmussen <sebrn@axis.com>
Date:   Wed Mar 6 19:51:11 2013 +0100

    check.mak: Add support for valgrinding all tests forever
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=695315