After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695289 - gst_buffer_copy_qdata replaces qdata (and leaks)
gst_buffer_copy_qdata replaces qdata (and leaks)
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.x
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-06 13:59 UTC by Haakon Sporsheim (ieei)
Modified: 2013-11-24 18:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Test case to show issue and leak (1.69 KB, patch)
2013-03-06 13:59 UTC, Haakon Sporsheim (ieei) 		none Details | Review

Description Haakon Sporsheim (ieei) 2013-03-06 13:59:58 UTC 
Created attachment 238198 [details] [review]
Test case to show issue and leak

If you do gst_buffer_copy_metadata() to transfer qdata from one buffer to another, the old qdata structures will be lost and leak.

See attached patch which currently fails.

Running both gst/gstbuffer.check and gst/gstbuffer.valgrind will obviously fail.
Comment 1 Tim-Philipp Müller 2013-03-11 00:32:19 UTC 
Got a fix as well?
Comment 2 Tim-Philipp Müller 2013-11-24 18:51:15 UTC 
Thanks for the bug report, but 0.10 is no longer maintained. We might've pushed a fix if it was obvious and non-intrusive, but I doubt anyone is going to investigate this further, and this code is different in 1.x, so let's close this bug.