Bug 695281 – USB sticks don't have can_stop == True

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 695281 - USB sticks don't have can_stop == True


Summary:	USB sticks don't have can_stop == True


Status:	RESOLVED OBSOLETE

Product:	gvfs
Classification:	Core
Component:	udisks2 volume monitor
Version:	git master
Hardware:	Other Linux

Importance:	Normal minor
Target Milestone:	---
Assigned To:	gvfs-maint
QA Contact:	gvfs-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2013-03-06 11:45 UTC by Martin Pitt
Modified:	2018-09-21 17:21 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Martin Pitt 2013-03-06 11:45:48 UTC

https://git.gnome.org/browse/gvfs/commit/?id=b3f72bac introduced a very nice heuristics for Eject vs. Safe Remove, i. e. setting can_stop.

https://git.gnome.org/browse/gvfs/commit/?id=cc6d3d29 limits this to media which don't have removable media. This is very sensible of course, as in general we want to show "Eject" for things like USB CD-Drives or MMC card readers.

The practical (and old and well-known) problem is that most USB sticks lie about this and claim that they have removable media. I. e.

$ cat /sys/block/sdb/removable 
1

which is what ultimately determines drive->is_media_removable, I believe.

It would be nice if we could loosen this requirement for can_stop, or add some heuristics to either gvfs' udisks2 monitor or udisks itself, but I realize this is going to be tricky. In particular, MMC/SD card readers look almost exactly like USB sticks sysfs-wise, except for having things like "Multi-Card" in their description and other device drivers.

Any ideas about that?

Comment 1 Nrbrtx 2013-04-27 15:24:30 UTC

Bug still exists in Fedora 18 (https://bugzilla.redhat.com/show_bug.cgi?id=919194), Ubuntu 13.04 (https://bugs.launchpad.net/ubuntu/+source/udisks2/+bug/1067876) and OpenSuSe 12.3 (https://bugzilla.novell.com/show_bug.cgi?id=808447).

Comment 2 Nrbrtx 2013-11-24 12:49:08 UTC

Bug exists in nautilus 3.10.1 (tested in Fedora 20).
Please fix it.

Comment 3 Nrbrtx 2014-01-18 12:37:11 UTC

Bug exists in nautilus 3.10.1 (tested in Arch).
Please fix it.

Comment 4 GNOME Infrastructure Team 2018-09-21 17:21:33 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gvfs/issues/201.