After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695260 - x11/xi2: Factor the XKB group state in to fill events' modifier_state
x11/xi2: Factor the XKB group state in to fill events' modifier_state
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-06 00:44 UTC by Rui Matos
Modified: 2013-03-06 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
x11/xi2: Factor the XKB group state in to fill events' modifier_state (6.21 KB, patch)
2013-03-06 00:44 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-03-06 00:44:29 UTC 
This patch basically makes _clutter_input_device_xi2_translate_state()
match the current code in the equivalent
_gdk_x11_device_xi2_translate_state() .
Comment 1 Rui Matos 2013-03-06 00:44:32 UTC 
Created attachment 238176 [details] [review]
x11/xi2: Factor the XKB group state in to fill events' modifier_state

Otherwise XkbTranslateKeyCode() won't yeld the correct keysyms when
group > 1.
Comment 2 Emmanuele Bassi (:ebassi) 2013-03-06 08:29:50 UTC 
Review of attachment 238176 [details] [review]:

looks good to me.
Comment 3 Rui Matos 2013-03-06 12:39:11 UTC 
Attachment 238176 [details] pushed as 40ef7a5 - x11/xi2: Factor the XKB group
state in to fill events' modifier_state

Pushed to both master and clutter-1.14