After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695242 - using 24 hour clock for forecast
using 24 hour clock for forecast
Status: RESOLVED FIXED
Product: gnome-weather
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Weather Maintainer(s)
GNOME Weather Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-05 19:21 UTC by William Jon McCann
Modified: 2013-03-05 22:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
forecast: use GSettings clock-format string instead of hardcoding 24h (1.61 KB, patch)
2013-03-05 19:34 UTC, Cosimo Cecchi 		needs-work Details | Review
forecast: use GSettings clock-format string instead of hardcoding 24h (1.78 KB, patch)
2013-03-05 22:25 UTC, Cosimo Cecchi 		committed Details | Review

Description William Jon McCann 2013-03-05 19:21:59 UTC 
It is using 24 hour clock for forecast even though my settings are 12 hour.
Comment 1 Cosimo Cecchi 2013-03-05 19:34:41 UTC 
Created attachment 238160 [details] [review]
forecast: use GSettings clock-format string instead of hardcoding 24h
Comment 2 Giovanni Campagna 2013-03-05 21:53:18 UTC 
Review of attachment 238160 [details] [review]:

::: src/forecast.js
@@ +247,3 @@
+            timeFormat = '%l:%M %p'
+        else
+            timeFormat = '%k:%M'

Needs to be translated.
Comment 3 Cosimo Cecchi 2013-03-05 22:25:40 UTC 
Created attachment 238166 [details] [review]
forecast: use GSettings clock-format string instead of hardcoding 24h

--

Now translatable and using the unicode ratio character instead of :
Comment 4 Giovanni Campagna 2013-03-05 22:49:40 UTC 
Review of attachment 238166 [details] [review]:

Yes.
Comment 5 Cosimo Cecchi 2013-03-05 22:51:21 UTC 
Attachment 238166 [details] pushed as 3611f9e - forecast: use GSettings clock-format string instead of hardcoding 24h