After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695212 - Add Help item in app menu
Add Help item in app menu
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.7.x
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-05 13:28 UTC by Michael Hill
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
app: Add 'Help' menu item (1.52 KB, patch)
2013-03-05 14:37 UTC, Zeeshan Ali 		committed Details | Review

Description Michael Hill 2013-03-05 13:28:31 UTC 
'Help' in the app menu should link to 'help:gnome-boxes'.
Comment 1 Zeeshan Ali 2013-03-05 14:37:00 UTC 
Created attachment 238134 [details] [review]
app: Add 'Help' menu item

This menu item takes you straight to Boxes help pages.
Comment 2 David King 2013-03-05 14:54:05 UTC 
Review of attachment 238134 [details] [review]:

Looks good to me, just a coding style question.

::: src/app.vala
@@ +122,3 @@
+        action.activate.connect (() => {
+            try {
+                Gtk.show_uri (window.get_screen(),

Not sure of the coding style you are using, but there is no space before opening bracket here, but there is on line 126 below.
Comment 3 Zeeshan Ali 2013-03-05 15:01:01 UTC 
Review of attachment 238134 [details] [review]:

::: src/app.vala
@@ +122,3 @@
+        action.activate.connect (() => {
+            try {
+                Gtk.show_uri (window.get_screen(),

Thanks for pointing out. I copy&pasted from documents and adapted. Guess I forgot this part. :)
Comment 4 Zeeshan Ali 2013-03-05 17:06:02 UTC 
Attachment 238134 [details] pushed as 98d3cab - app: Add 'Help' menu item