After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695205 - Remove ephy-file-helpers dependency from uri-tester
Remove ephy-file-helpers dependency from uri-tester
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on: 695198
Blocks:
 
 
Reported: 2013-03-05 12:01 UTC by Carlos Garcia Campos
Modified: 2013-03-06 11:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (7.75 KB, patch)
2013-03-05 12:03 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2013-03-05 12:01:29 UTC 
Only ephy_dot_dir() is used, so we can just pass the base data dir as a construct property to uri tester.
Comment 1 Carlos Garcia Campos 2013-03-05 12:03:21 UTC 
Created attachment 238121 [details] [review]
Patch

Also fixes some memory leaks because the string returned by uri_tester_ensure_data_dir was not freed in most of the cases.
Comment 2 Xan Lopez 2013-03-05 18:33:51 UTC 
Review of attachment 238121 [details] [review]:

Also looks good.