After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695192 - tests fail: lib/ephy-profile-utils.c missing from POTFILES.{in|skip}
tests fail: lib/ephy-profile-utils.c missing from POTFILES.{in|skip}
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: I18N
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-05 09:19 UTC by Martin Pitt
Modified: 2013-03-05 09:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
POTFILES.in: add missing file (628 bytes, patch)
2013-03-05 09:27 UTC, Claudio Saavedra
committed Details | Review

Description Martin Pitt 2013-03-05 09:19:49 UTC
"make check" fails for epiphany with:

make[1]: Entering directory `/home/ubuntu/gnome/checkout/epiphany/po'
rm -f missing notexist
srcdir=. /home/ubuntu/gnome/packages/bin/intltool-update -m
The following files contain translations and are currently not in use. Please
consider adding these to the POTFILES.in file, located in the po/ directory.

lib/ephy-profile-utils.c

If some of these files are left out on purpose then please add them to
POTFILES.skip instead of POTFILES.in. A file 'missing' containing this list
of left out files has been written in the current directory.
Please report to http://bugzilla.gnome.org/enter_bug.cgi?product=epiphany

Indeed it does have a human readable string which looks like it should be made translatable:

  /* Translators: The first %s is the username and the second one is the
   * hostname where this is happening. Example: gnome@gmail.com and
   * mail.google.com.
   */
  label = g_strdup_printf (_("Password for %s in a form in %s"),
                           username, fake_uri_str);

Want me to just push the addition to POTFILES.in?

When I do this, the tests at least run, but one fails with

  /lib/ephy-profile-utils/do_migration_invalid:                        **
ERROR:ephy-migration-test.c:49:test_do_migration_invalid: assertion failed: (ret == FALSE)
FAIL
Comment 1 Claudio Saavedra 2013-03-05 09:27:31 UTC
Created attachment 238101 [details] [review]
POTFILES.in: add missing file
Comment 2 Claudio Saavedra 2013-03-05 09:27:58 UTC
Attachment 238101 [details] pushed as bd8a755 - POTFILES.in: add missing file