Bug 695186 – system: Fix leak in addressOf()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 695186 - system: Fix leak in addressOf()


Summary:	system: Fix leak in addressOf()

Attachments
system: Fix leak in addressOf() (675 bytes, patch) 2013-03-05 07:06 UTC, Pavel Vasin	committed	Details \| Review
Add test for System.addressOf() (798 bytes, patch) 2013-03-05 07:06 UTC, Pavel Vasin	needs-work	Details \| Review
Add test for System.addressOf() v2 (1.16 KB, patch) 2013-03-05 14:14 UTC, Pavel Vasin	committed	Details \| Review

Description Pavel Vasin 2013-03-05 07:05:48 UTC

Comment 1 Pavel Vasin 2013-03-05 07:06:14 UTC

Created attachment 238090 [details] [review]
system: Fix leak in addressOf()

Comment 2 Pavel Vasin 2013-03-05 07:06:43 UTC

Created attachment 238093 [details] [review]
Add test for System.addressOf()

Comment 3 Giovanni Campagna 2013-03-05 13:54:05 UTC

Review of attachment 238090 [details] [review]:

Nice catch!

Comment 4 Giovanni Campagna 2013-03-05 13:54:36 UTC

Review of attachment 238093 [details] [review]:

Needs to be added to Makefile-test.am

Comment 5 Pavel Vasin 2013-03-05 14:14:36 UTC

Created attachment 238131 [details] [review]
Add test for System.addressOf() v2

>Needs to be added to Makefile-test.am

Done.

Comment 6 Giovanni Campagna 2013-03-05 14:15:39 UTC

Review of attachment 238131 [details] [review]:

Yes.

Comment 7 Pavel Vasin 2013-03-13 08:15:21 UTC

Please commit. I don't have git account.

Comment 8 Giovanni Campagna 2013-03-13 16:46:40 UTC

Done, thank you very much for your patches!