After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695135 - memory leaks
memory leaks
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-04 16:31 UTC by Pavel Vasin
Modified: 2013-03-04 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Free memory allocated by XIQueryPointer() (2.38 KB, patch)
2013-03-04 16:31 UTC, Pavel Vasin 		needs-work Details | Review
window-actor: Fix leaked opaque_region (830 bytes, patch)
2013-03-04 16:31 UTC, Pavel Vasin 		committed Details | Review
window-actor: Fix leaked frame list (836 bytes, patch)
2013-03-04 16:32 UTC, Pavel Vasin 		committed Details | Review
Free memory allocated by XIQueryPointer() v2 (2.93 KB, patch)
2013-03-04 17:39 UTC, Pavel Vasin 		committed Details | Review

Description Pavel Vasin 2013-03-04 16:31:06 UTC 
See patches...
Comment 1 Pavel Vasin 2013-03-04 16:31:26 UTC 
Created attachment 238013 [details] [review]
Free memory allocated by XIQueryPointer()
Comment 2 Pavel Vasin 2013-03-04 16:31:46 UTC 
Created attachment 238014 [details] [review]
window-actor: Fix leaked opaque_region
Comment 3 Pavel Vasin 2013-03-04 16:32:06 UTC 
Created attachment 238015 [details] [review]
window-actor: Fix leaked frame list
Comment 4 Florian Müllner 2013-03-04 17:07:43 UTC 
Review of attachment 238014 [details] [review]:

Looks good.
Comment 5 Florian Müllner 2013-03-04 17:14:15 UTC 
Review of attachment 238015 [details] [review]:

OK.
Comment 6 Florian Müllner 2013-03-04 17:24:05 UTC 
Review of attachment 238013 [details] [review]:

Yes, but please make sure to include <stdlib.h> anywhere you are adding a call to free().
Comment 7 Pavel Vasin 2013-03-04 17:39:32 UTC 
Created attachment 238023 [details] [review]
Free memory allocated by XIQueryPointer() v2

>Yes, but please make sure to include <stdlib.h> anywhere you are adding a call
>to free().

Done.
Comment 8 Florian Müllner 2013-03-04 17:43:32 UTC 
Review of attachment 238023 [details] [review]:

Thanks. Do you have a git account or do you need someone to push these for you?
Comment 9 Pavel Vasin 2013-03-04 18:04:41 UTC 
I don't have a git account. Please commit.
Comment 10 Florian Müllner 2013-03-04 18:08:03 UTC 
Attachment 238014 [details] pushed as 7db236b - window-actor: Fix leaked opaque_region
Attachment 238015 [details] pushed as 4d437e3 - window-actor: Fix leaked frame list

OK - thanks for the patches btw!