GNOME Bugzilla – Bug 695127
Add avahi dependency for gtk+
Last modified: 2013-03-13 14:42:04 UTC
Created attachment 237996 [details] [review] add avahi dependency for gtk+ Gtk+ needs Avahi for listing printers advertised by CUPS over Avahi. For additional info see https://bugzilla.gnome.org/show_bug.cgi?id=688956. Attached patch adds this dependency.
This will create a circular dependency between avahi and gtk+, on given your chance jhbuild will pick one over the other when building modules; I'd suggest changing this dependency into a <suggest>, so the dependency resolution will know it's possible to build gtk+ without avahi support. Also there's already a avahi module defined in gnome-suites-core-3.8.modules; you don't need to redefine it.
Created attachment 238022 [details] [review] add avahi dependency for gtk+ - modified Hi, (In reply to comment #1) > This will create a circular dependency between avahi and gtk+, on given your > chance jhbuild will pick one over the other when building modules; I'd suggest > changing this dependency into a <suggest>, so the dependency resolution will > know it's possible to build gtk+ without avahi support. I see that Avahi has "--disable-gtk --disable-gtk3" flags among its autogenargs so I removed the gtk+ from avahi's dependencies. This should break the circular dependency (but I'm not skilled in JHBuild, please correct me if I'm wrong). > Also there's already a avahi module defined in gnome-suites-core-3.8.modules; > you don't need to redefine it. I've removed the definition of Avahi from gnome-suites-core-3.8.modules because it includes gnome-suites-core-deps-3.8.modules. Marek
Hi, I've changed those calls to Avahi API to calls to Avahi's DBus API. We don't need to add build dependency on Avahi to Gtk+ now. Regards Marek For additional info see https://bugzilla.gnome.org/show_bug.cgi?id=695715 and https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-8&id=67c08d7c1de8d9fc6dcf8afc37f7c199d24029aa.