After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695116 - gnome-bg: fix mem leak
gnome-bg: fix mem leak
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: Background
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-04 11:57 UTC by Pavel Vasin
Modified: 2013-05-13 15:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-bg: fix mem leak (774 bytes, patch)
2013-03-04 11:57 UTC, Pavel Vasin 		needs-work Details | Review
gnome-bg: fix mem leak v2 (769 bytes, patch)
2013-03-25 13:13 UTC, Pavel Vasin 		committed Details | Review

Description Pavel Vasin 2013-03-04 11:57:11 UTC 
Created attachment 237954 [details] [review]
gnome-bg: fix mem leak

patch attached
Comment 1 Bastien Nocera 2013-03-25 11:25:18 UTC 
Review of attachment 237954 [details] [review]:

::: libgnome-desktop/gnome-bg-slide-show.c
@@ +736,2 @@
     loaded = g_file_load_contents_finish (file, result, &contents, &length, NULL, &error);
+    g_object_unref (file);

The file should be unreferenced as soon as g_file_load_contents_async() is called, as the function will hold a reference to it until the callback has finished.
Comment 2 Pavel Vasin 2013-03-25 13:13:25 UTC 
Created attachment 239762 [details] [review]
gnome-bg: fix mem leak v2

>The file should be unreferenced as soon as g_file_load_contents_async() is called

Done.
Comment 3 Bastien Nocera 2013-03-25 13:21:13 UTC 
Review of attachment 239762 [details] [review]:

Looks good. We'll get it in GNOME 3.8.1 and master after the freeze (the leak isn't big enough to ask for a freeze break).
Comment 4 Pavel Vasin 2013-05-13 14:30:14 UTC 
Ping. Please commit.