After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695115 - dbus: Only return one object path list from Collection.SearchItems()
dbus: Only return one object path list from Collection.SearchItems()
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-04 11:44 UTC by Stef Walter
Modified: 2013-03-16 09:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dbus: Only return one object path list from Collection.SearchItems() (14.80 KB, patch)
2013-03-04 11:44 UTC, Stef Walter 		committed Details | Review
Update introspection to match the new SearchItems behavior (1.15 KB, patch)
2013-03-10 08:55 UTC, Dmitry Shachnev 		committed Details | Review

Description Stef Walter 2013-03-04 11:44:41 UTC 
gnome-keyring incorrectly returns two arrays from the SearchItems()
method of the Collection interface.
Comment 1 Stef Walter 2013-03-04 11:44:52 UTC 
Created attachment 237953 [details] [review]
dbus: Only return one object path list from Collection.SearchItems()

In the Secret Service dbus interface the SearchItems method
of the Collection interface only returns one list of object
paths, unlike SearchItems on the Service interface which
splits its return values by locked and unlocked items.

Add tests to verify this behavior.
Comment 2 Stef Walter 2013-03-04 11:49:03 UTC 
Dmitry, could you review the attached patch? If you don't have time, let me
know, and I'll see if I can find someone else to do so.
Comment 3 Dmitry Shachnev 2013-03-04 11:54:02 UTC 
Review of attachment 237953 [details] [review]:

Looks good, thank you!
Comment 4 Stef Walter 2013-03-04 11:56:26 UTC 
Attachment 237953 [details] pushed as ddb87cc - dbus: Only return one object path list from Collection.SearchItems()
Comment 5 Dmitry Shachnev 2013-03-10 08:55:36 UTC 
Created attachment 238504 [details] [review]
Update introspection to match the new SearchItems behavior
Comment 6 Dmitry Shachnev 2013-03-13 15:28:40 UTC 
Stef, can you please look at the introspection patch above?

I've forgot "dbus:" in the commit message, hopefully it's not critical (or you can add it while committing).
Comment 7 Stef Walter 2013-03-14 06:02:14 UTC 
Comment on attachment 238504 [details] [review]
Update introspection to match the new SearchItems behavior

Thanks pushed. Let me know if there's any patches you'd like backported to the gnome-3-6 branch.
Comment 8 Dmitry Shachnev 2013-03-15 13:59:35 UTC 
> Thanks pushed.
Thank you!

> Let me know if there's any patches you'd like backported to the gnome-3-6 branch.
I was asked to ask you (:P) to backport both patches from this bug and one from bug 690765.
Comment 9 Stef Walter 2013-03-16 07:51:33 UTC 
Done
Comment 10 Dmitry Shachnev 2013-03-16 09:53:16 UTC 
Not really, I meant *both* patches from this bug — including your patch in comment 1 :)