GNOME Bugzilla – Bug 695099
a11y: A new design for the a11y panel
Last modified: 2013-07-19 11:04:00 UTC
See https://live.gnome.org/Design/SystemSettings/UniversalAccess The status switch is not implemented yet.
Created attachment 237920 [details] [review] patch
Created attachment 241500 [details] [review] a11y: A new design for the a11y panel A new design for the universal acccess panel: https://live.gnome.org/Design/SystemSettings/UniversalAccess The status switch is not implemented yet.
The newer patch impelements the status switch. See the blocking shell bug for the shell-side of the functionality.
Let me know where you would like the status switch setting to live. For now, I've just put it in org.gnome.shell
Review of attachment 241500 [details] [review]: I haven't actually run the program yet. All the float values need rounding, and the Short/Long strings need context (and translator comments). ::: panels/universal-access/cc-ua-panel.c @@ +387,3 @@ + connect_focus (list, self); + + priv->sections_reverse = g_list_prepend (priv->sections_reverse, list); Can you split this off into its own function? @@ +651,2 @@ + w = WID ("typing_slowkeys_beep_pressed_check"); + g_settings_bind (priv->kb_settings, KEY_SLOWKEYS_BEEP_PRESS, The g_setting_bind() and g_object_bind_property() calls could probably be factored out. @@ +781,3 @@ +on_content_size_changed (GtkWidget *content, GtkAllocation *allocation, GtkWidget *panel) +{ + if (allocation->height < 490) Magic number should be a define. Can you also explain how you got this number? @@ +790,3 @@ + gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (panel), + GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC); + gtk_scrolled_window_set_min_content_height (GTK_SCROLLED_WINDOW (panel), 490); Same magic number. ::: panels/universal-access/uap.ui @@ +168,3 @@ + <property name="margin_bottom">6</property> + <property name="xalign">1</property> + <property name="label" translatable="yes">Off</property> Context. @@ +1487,3 @@ + <property name="xalign">1</property> + <property name="xpad">10</property> + <property name="label" translatable="yes">Short</property> Context. @@ +1490,2 @@ <attributes> + <attribute name="scale" value="0.82999999999999996"/> Round. @@ +1523,3 @@ + <property name="label" translatable="yes">Long</property> + <attributes> + <attribute name="scale" value="0.82999999999999996"/> Round. @@ +1703,2 @@ <attributes> + <attribute name="scale" value="0.82999999999999996"/> Round. @@ +1736,3 @@ + <property name="label" translatable="yes">Long</property> + <attributes> + <attribute name="scale" value="0.82999999999999996"/> Round. @@ +2065,3 @@ <property name="can_focus">False</property> + <property name="xalign">1</property> + <property name="yalign">0.4699999988079071</property> 0.5? @@ +2069,2 @@ <attributes> + <attribute name="scale" value="0.82999999999999996"/> Round. @@ +2102,3 @@ + <property name="label" translatable="yes" comments="long delay">Long</property> + <attributes> + <attribute name="scale" value="0.82999999999999996"/> Round. @@ +2264,3 @@ + <property name="justify">center</property> + <attributes> + <attribute name="scale" value="0.82999999999999996"/> Round. @@ +2353,3 @@ + <property name="justify">center</property> + <attributes> + <attribute name="scale" value="0.82999999999999996"/> Round.
Created attachment 244659 [details] [review] a11y: A new design for the a11y panel A new design for the universal acccess panel: https://live.gnome.org/Design/SystemSettings/UniversalAccess The status switch is not implemented yet.
The new version incorporates most of the review feedback, addresses some alignment and padding issues, and makes mnemonic activation work for all rows. The magic number was copied from the power panel - we probably don't need the hide-the-scrollbar code here anyway, because the a11y panel is always so large that we need it (the power panel can shrink to almost nothing).
Created attachment 244676 [details] [review] a11y: A new design for the a11y panel A new design for the universal acccess panel: https://live.gnome.org/Design/SystemSettings/UniversalAccess
Now with the always-show key moved to org.gnome.desktop.a11y
Review of attachment 244676 [details] [review]: Need to bump the gsettings-desktop-schemas dep The keyboard shortcuts and links to other panels seem to have completely disappeared. ::: panels/universal-access/cc-ua-panel.c @@ +189,3 @@ + + factor = g_variant_get_double (variant); + g_value_set_string (value, factor != DPI_FACTOR_NORMAL ? _("On") : _("Off")); a DPI factor of 0.75 on my machine shows up as having large text enabled. ::: panels/universal-access/uap.ui @@ -12,3 @@ - <property name="upper">3</property> - <property name="value">1.2</property> - <property name="step_increment">0.10000000000000001</property> Still numbers that need rounding. @@ +274,2 @@ <property name="xalign">0</property> + <property name="label" translatable="yes">_Sound Keys</property> Sound keys don't seem to work for me. @@ +369,3 @@ + <property name="margin_bottom">6</property> + <property name="xalign">0</property> + <property name="label" translatable="yes">_Visual Alerts</property> The visual alerts are truly awful and barely noticeable. Please file the necessary bugs for that to get fixed. @@ +600,3 @@ + <property name="margin_bottom">6</property> + <property name="xalign">0</property> + <property name="label" translatable="yes">_Mouse Keys</property> What's "Mouse Keys"? The current panel has an explanation of what this is ("Control the pointer using the keypad") @@ +813,3 @@ + </child> + <child> + <object class="GtkSpinButton" id="text_scaling_factor_spin"> We really don't want a spin button here. Previously, this was a drop-down menu with a number of possible values. The mockup makes me think that this should just be a toggle and not have a separate dialogue. @@ +844,3 @@ + <property name="xalign">0</property> + <property name="max-width-chars">45</property> + <property name="label" translatable="yes">Control the overall text size. If this is not sufficient, try the Zoom feature.</property> Are those 2 separate controls to handle the same setting?
(In reply to comment #10) > Review of attachment 244676 [details] [review]: > > Need to bump the gsettings-desktop-schemas dep > > The keyboard shortcuts and links to other panels seem to have completely > disappeared. The design doesn't have them. And the dialog-heavy design makes it hard to do such links. > @@ +274,2 @@ > <property name="xalign">0</property> > + <property name="label" > translatable="yes">_Sound Keys</property> > > Sound keys don't seem to work for me. Its one of the accessx features - I think we used to only expose it as part of sticky keys before ('beep when a modifier is pressed'). All the beeping functionality seems to be tied up with event sounds - they only work here if I enable event sounds - thats arguably a bug. We should either have a separate role for these a11y sounds, or we should turn on event sounds when a11y needs it. > @@ +369,3 @@ > + <property > name="margin_bottom">6</property> > + <property name="xalign">0</property> > + <property name="label" > translatable="yes">_Visual Alerts</property> > > The visual alerts are truly awful and barely noticeable. Please file the > necessary bugs for that to get fixed. Right, I had already noticed that. bug 700863 > @@ +600,3 @@ > + <property > name="margin_bottom">6</property> > + <property name="xalign">0</property> > + <property name="label" > translatable="yes">_Mouse Keys</property> > > What's "Mouse Keys"? > The current panel has an explanation of what this is ("Control the pointer > using the keypad") Mouse keys is the name used in Windows for this: http://windows.microsoft.com/en-us/windows-xp/help/turn-on-mousekeys > @@ +813,3 @@ > + </child> > + <child> > + <object class="GtkSpinButton" id="text_scaling_factor_spin"> > > We really don't want a spin button here. Previously, this was a drop-down menu > with a number of possible values. > The mockup makes me think that this should just be a toggle and not have a > separate dialogue. Yeah, the design didn't have it, but I felt that it would be nice to provide a dialog here and make the scaling factor available. Why do you think that the spin button is bad ? In any case, we can certainly make it a drop-down. What values did the old one have ? > @@ +844,3 @@ > + <property name="xalign">0</property> > + <property name="max-width-chars">45</property> > + <property name="label" translatable="yes">Control the overall text > size. If this is not sufficient, try the Zoom feature.</property> > > Are those 2 separate controls to handle the same setting? Yes. Do you want just a drop-down ?
Bastien, could you answer the questions in my previous comments, so we can wrap this up ?
Created attachment 249597 [details] [review] universal-access: Updated design A new design for the universal acccess panel: https://live.gnome.org/Design/SystemSettings/UniversalAccess Rev 1: - Ported to GtkListBox - Fix small scale factors being detected as large text TODO: - Mockup for "Large text" dialogue - Re-indent glade file
Created attachment 249613 [details] [review] universal-access: Updated design A new design for the universal acccess panel: https://live.gnome.org/Design/SystemSettings/UniversalAccess Rev 2: - Ported to GtkListBox - Really fix small scale factors being detected as large text - Remove large text dialogue (and just use a switch) Reindenting the glade file will have to wait :)
Created attachment 249614 [details] [review] universal-access: Updated design A new design for the universal acccess panel: https://live.gnome.org/Design/SystemSettings/UniversalAccess Rev 3: - Ported to GtkListBox - Really fix small scale factors being detected as large text - Remove large text dialogue (and just use a switch) - Indented the glade file
Attachment 249614 [details] pushed as 145ffcb - universal-access: Updated design