GNOME Bugzilla – Bug 695090
rganalysis: fix tests
Last modified: 2013-09-18 16:47:39 UTC
Created attachment 237913 [details] [review] fix tests Warning: I don't know what I'm doing. All tests failed for basically the same reason: Tags send explicitly with 'send_tag_event' were not expected by the tests. I changed it to check the tag values (if they come from the analysis or not) and that the analysis tags come last.
*** Bug 684676 has been marked as a duplicate of this bug. ***
Thanks for the patch. I'm not 100% sure yet if it's right, will need to have a proper look later. It would be great if you could create patches in git format-patch format next time.
Created attachment 239129 [details] [review] patch
Tim, you set the status to assigned. Any updates ? I gave the patch a go, it applies cleanly on current master and does make all previously skipped tests pass.
Thanks for the patch! Your analysis seems correct, and the patch looks fine too, I've pushed it now. Sorry it took so long: commit 966f848edb70a6d6b7d172b842a8ceb600e4d747 Author: Tim-Philipp Müller <tim@centricular.net> Date: Mon Sep 2 23:00:29 2013 +0100 replaygain: fix taglist leak in rganalysis And add some FIXMEs. commit cc4f985332d65fff9af165006b661e887a434172 Author: Tim-Philipp Müller <tim@centricular.net> Date: Mon Sep 2 22:50:58 2013 +0100 tests: rganalysis: rename function for clarity commit 92dde0760ba17f4df4a0a68a552f953161c83569 Author: Christoph Reiter <reiter.christoph@gmail.com> Date: Mon Mar 18 14:32:07 2013 +0100 tests: fix skipped rganalysis tests In 0.10 elements would post tag messages on the bus directly, and rganalysis would only post a tag message when it changed tags. In 1.0, only sinks post tag messages when they receive the serialised tag event. This means that we get an additional tag message on the bus now where we didn't expect one before. https://bugzilla.gnome.org/show_bug.cgi?id=695090 Having said that, the tag handling in rganalysis is very dodgy and broken in some respects, but that's independent from this patch and the tests.