After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695065 - build: Tell git.mk to ignore generated files
build: Tell git.mk to ignore generated files
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-03 17:39 UTC by Emanuele Aina
Modified: 2013-03-04 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Tell git.mk to ignore generated files (2.19 KB, patch)
2013-03-03 17:39 UTC, Emanuele Aina 		none Details | Review
build: Tell git.mk to ignore generated files (2.19 KB, patch)
2013-03-04 12:49 UTC, Debarshi Ray 		none Details | Review
build: Tell git.mk to ignore generated files (2.18 KB, patch)
2013-03-04 13:38 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2013-03-03 17:39:26 UTC 
After building, many leftover files are still visible with `git status'. To
avoid the clutter there should be added to the *CLEANFILES automake variables
to make git.mk aware of them.
Comment 1 Emanuele Aina 2013-03-03 17:39:28 UTC 
Created attachment 237884 [details] [review]
build: Tell git.mk to ignore generated files
Comment 2 Debarshi Ray 2013-03-04 12:49:20 UTC 
Created attachment 237973 [details] [review]
build: Tell git.mk to ignore generated files

Thanks for the patch!

I made some minor stylistic changes. However, I still get this:
[rishi@kolache gnome-online-accounts]$ git status
# On branch master
# Your branch is ahead of 'origin/master' by 1 commit.
#   (use "git push" to publish your local commits)
#
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.Calendar.xml
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.Chat.xml
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.Contacts.xml
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.Documents.xml
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.Exchange.xml
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.Files.xml
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.Mail.xml
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.Manager.xml
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.OAuth2Based.xml
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.OAuthBased.xml
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.PasswordBased.xml
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.Photos.xml
#	src/goa/goa-generated-doc-org.gnome.OnlineAccounts.Ticketing.xml
nothing added to commit but untracked files present (use "git add" to track)
[rishi@kolache gnome-online-accounts]$
Comment 3 Emanuele Aina 2013-03-04 13:38:45 UTC 
Created attachment 237981 [details] [review]
build: Tell git.mk to ignore generated files

Do not expand files to be ignored with $(wildcard) as git happily accepts the
shell pattern and the expansion does not work if the files to be ignored aren't
already present (ie. on a clean checkout).
Comment 4 Debarshi Ray 2013-03-04 14:25:07 UTC 
Comment on attachment 237981 [details] [review]
build: Tell git.mk to ignore generated files

Works very well.