After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695059 - Emblemed icons overwrite information in GtkIconInfo
Emblemed icons overwrite information in GtkIconInfo
Status: RESOLVED DUPLICATE of bug 694968
Product: gtk+
Classification: Platform
Component: Widget: Other
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-03-03 15:38 UTC by Benjamin Berg
Modified: 2013-03-03 20:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that fixes the issue by copying the icon_info before modification (981 bytes, application/octet-stream)
2013-03-03 15:38 UTC, Benjamin Berg
Details

Description Benjamin Berg 2013-03-03 15:38:42 UTC
Created attachment 237878 [details]
Patch that fixes the issue by copying the icon_info before modification

gtk_icon_theme_lookup_by_gicon has an issue where it modifies cached data. This can for example be seen in the evolution folder list when new mail arrives in a subfolder. It works as follows:

 1. Normal (non-stared) folder is drawn, and the icon info for it is cached by gtk_icon_theme_choose_icon
 2. Emblemed version is drawn
 3. gtk_icon_theme_lookup_by_gicon looks up the non-emblemed icon using gtk_icon_theme_lookup_by_gicon
 4. gtk_icon_theme_lookup_by_gicon returns cached icon info from gtk_icon_theme_choose_icon
 5. gtk_icon_theme_lookup_by_gicon modifies the returned icon info and adds the emblem information

From this point onwards the GtkIconInfo for the non-emblemed version contains the emblem list.

Attach patch fixes it for me.
Comment 1 Cosimo Cecchi 2013-03-03 20:24:32 UTC
Looks the same issue reported in bug 694968 (and almost the same patch too).

*** This bug has been marked as a duplicate of bug 694968 ***